Update class literal display to use <class 'Foo'> style#17889
Merged
charliermarsh merged 4 commits intomainfrom May 7, 2025
Merged
Update class literal display to use <class 'Foo'> style#17889charliermarsh merged 4 commits intomainfrom
<class 'Foo'> style#17889charliermarsh merged 4 commits intomainfrom
Conversation
Member
Author
|
Want to make sure I'm on the right track before I update the remaining tests. |
Contributor
|
AlexWaygood
reviewed
May 6, 2025
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
This is looking great to me so far! Probably best to wait for at least one other person to give the thumbs up before proceeding further, though 😄
Comment on lines
46
to
47
| | Type::GenericAlias(_) => { | ||
| write!(f, "Literal[{representation}]") | ||
| } |
Member
There was a problem hiding this comment.
we probably want to make the same update for Type::GenericAlias
Contributor
|
This is looking good to me as well! |
40216f3 to
77958c5
Compare
9796263 to
e69756f
Compare
carljm
approved these changes
May 6, 2025
| @@ -605,7 +604,6 @@ impl Display for DisplayLiteralGroup<'_> { | |||
| /// For example, `Literal[1] | Literal[2] | Literal["s"]` is displayed as `"Literal[1, 2, "s"]"`. | |||
| #[derive(Copy, Clone, Debug, Eq, PartialEq, Hash)] | |||
| enum CondensedDisplayTypeKind { | |||
Contributor
There was a problem hiding this comment.
I don't think we are going to add more of these, so I think we could remove this enum entirely and simplify the literal display code to not need to consider multiple "kinds" at all.
But I'm not going to hold up this PR for that, gonna land this quick before there are any conflicts.
Member
Author
There was a problem hiding this comment.
Cool I can do it as a follow-up.
Contributor
|
Hmm I noticed after my review that all the CI checks were stuck in some kind of pending state; after closing and reopening to nudge the CI, it seems a few tests are still failing? |
Member
Author
|
Oh strange, I can fix. |
e69756f to
1de758a
Compare
Member
Author
|
|
carljm
pushed a commit
that referenced
this pull request
May 7, 2025
## Summary See: #17889 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17238.