Skip to content

[ty] Support generate-shell-completion#17879

Merged
carljm merged 2 commits intoastral-sh:mainfrom
InSyncWithFoo:ty-shell-completion
May 7, 2025
Merged

[ty] Support generate-shell-completion#17879
carljm merged 2 commits intoastral-sh:mainfrom
InSyncWithFoo:ty-shell-completion

Conversation

@InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented May 6, 2025 •
edited
Loading

Summary

Resolves #15502.

ty generate-shell-completion now works in a similar manner to ruff generate-shell-completion.

Test Plan

Manually:

Details 
$ cargo run --package ty generate-shell-completion nushell
module completions {

  # An extremely fast Python type checker.
  export extern ty [
    --help(-h)                # Print help
    --version(-V)             # Print version
  ]
  
  # ...

}

export use completions *

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025 •
edited
Loading

mypy_primer results

No ecosystem changes detected ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

mesonbuild/meson-python (error) 

warning: Detected debug build without --no-cache.
error: Failed to read tests/packages/symlinks/baz.py: No such file or directory (os error 2)
error: Failed to read tests/packages/symlinks/qux.py: No such file or directory (os error 2)

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

mesonbuild/meson-python (error) 

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read tests/packages/symlinks/baz.py: No such file or directory (os error 2)
error: Failed to read tests/packages/symlinks/qux.py: No such file or directory (os error 2)

@AlexWaygood AlexWaygood removed their request for review May 6, 2025 06:37
@AlexWaygood AlexWaygood added the ty Multi-file analysis & type inference label May 6, 2025
MichaReiser
MichaReiser approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I've come around to accept ty generate-shell-completion because I think ty completion might be confusing, considering that ty provides completions in editors.

@MichaReiser
Copy link
Member

MichaReiser commented May 6, 2025

This is ready to go but requires a rebase

@carljm carljm removed their request for review May 6, 2025 17:37
@carljm carljm merged commit a33d0d4 into astral-sh:main May 7, 2025
35 checks passed
dcreager added a commit that referenced this pull request May 7, 2025
@dcreager
Merge branch 'main' into dcreager/legacy-variance
34bfa31 
* main:
  [ty] Support `generate-shell-completion` (#17879)
  Remove condensed display type enum (#17902)
  Update class literal display to use `<class 'Foo'>` style (#17889)
@InSyncWithFoo InSyncWithFoo deleted the ty-shell-completion branch May 7, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager is a code owner

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[red-knot] Shell completion

4 participants

@InSyncWithFoo @MichaReiser @carljm @AlexWaygood