Merged
Conversation
MichaReiser
commented
Dec 17, 2024
| let file = definition.file(db); | ||
| let _span = tracing::trace_span!( | ||
| "infer_definition_types", | ||
| definition = ?definition.as_id(), |
Member
Author
There was a problem hiding this comment.
I don't think the definition id gives us much here and it resulted in very long tracing lines but I'll revert if this ends up being controverisal
Contributor
|
dcreager
added a commit
that referenced
this pull request
Dec 17, 2024
* main: [red-knot] Explicitly test diagnostics are emitted for unresolvable submodule imports (#15035) Fix stale File status in tests (#15030) [red-knot] Basic support for other legacy `typing` aliases (#14998) feat(AIR302): extend the following rules (#15015) [`perflint`] Simplify finding the loop target in `PERF401` (#15025) [red-knot] Avoid undeclared path when raising conflicting declarations (#14958)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15027
The
MemoryFileSystem::write_fileAPI automatically creates non-existing ancestor directoryesbut we failed to update the status of the now created ancestor directories in the
Filesdata structure.Test Plan
Tested that the case in #15027 now passes regardless of whether the Simple case is commented out or not