[red-knot] Understand other legacy typing aliases#14998
Merged
AlexWaygood merged 9 commits intoastral-sh:mainfrom Dec 17, 2024
Merged
[red-knot] Understand other legacy typing aliases#14998AlexWaygood merged 9 commits intoastral-sh:mainfrom
typing aliases#14998AlexWaygood merged 9 commits intoastral-sh:mainfrom
Conversation
Contributor
|
AlexWaygood
reviewed
Dec 16, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks. I think we'll probably have to rewrite a lot of this when we add support for generics, but I suppose there's no harm in improving our understanding of these annotations as best we can in the meantime
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Dec 16, 2024
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
Dec 16, 2024
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md
Outdated
Show resolved
Hide resolved
dcreager
added a commit
that referenced
this pull request
Dec 17, 2024
* main: [red-knot] Explicitly test diagnostics are emitted for unresolvable submodule imports (#15035) Fix stale File status in tests (#15030) [red-knot] Basic support for other legacy `typing` aliases (#14998) feat(AIR302): extend the following rules (#15015) [`perflint`] Simplify finding the loop target in `PERF401` (#15025) [red-knot] Avoid undeclared path when raising conflicting declarations (#14958)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #14997.
Test Plan
Markdown tests.