[red-knot] preparse builtins in without_parse benchmark#12395
Merged
MichaReiser merged 2 commits intomainfrom Jul 19, 2024
Merged
[red-knot] preparse builtins in without_parse benchmark#12395MichaReiser merged 2 commits intomainfrom
MichaReiser merged 2 commits intomainfrom
Conversation
Contributor
|
MichaReiser
approved these changes
Jul 19, 2024
CodSpeed Performance ReportMerging #12395 will not alter performanceComparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding builtins support in #12390, we should pre-parse builtins also in the
without_parsebenchmark, so the builtins-parsing time is not included.The "cold" benchmark should include everything, so it doesn't need to be modified.
The "incremental" benchmark should already exclude parsing builtins (unless we have a bug that causes it to be re-parsed even when it hasn't changed, which we'd want this benchmark to catch.)