[red-knot] unswap naming of benchmark groups#12396
Merged
MichaReiser merged 1 commit intocjm/bench-preparse-builtinsfrom Jul 19, 2024
Merged
[red-knot] unswap naming of benchmark groups#12396MichaReiser merged 1 commit intocjm/bench-preparse-builtinsfrom
MichaReiser merged 1 commit intocjm/bench-preparse-builtinsfrom
Conversation
CodSpeed Performance ReportMerging #12396 will not alter performanceComparing Summary
Benchmarks breakdown
|
5600b49 to
d901769
Compare
Contributor
|
MichaReiser
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless there's some logic in
criterion_group!that I really don't understand, it looks like these benchmark group names were swapped, so the group labeledwithout_parsewas actually thecoldbenchmark, and vice versa. Not sure this practically matters, since the benchmark function names were correct.