Skip to content

Remove Tok enum#11628

Merged
dhruvmanila merged 1 commit intodhruv/parser-phase-2from
dhruv/remove-tok
May 31, 2024
Merged

Remove Tok enum#11628
dhruvmanila merged 1 commit intodhruv/parser-phase-2from
dhruv/remove-tok

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented May 31, 2024

Summary

This PR removes the Tok enum now that all of it's dependencies have been updated to use TokenKind instead.

closes: #11401

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label May 31, 2024
@dhruvmanila dhruvmanila requested a review from MichaReiser as a code owner May 31, 2024 04:52
@dhruvmanila dhruvmanila merged commit 37a9b84 into dhruv/parser-phase-2 May 31, 2024
@dhruvmanila dhruvmanila deleted the dhruv/remove-tok branch May 31, 2024 04:52
@dhruvmanila dhruvmanila mentioned this pull request May 31, 2024
Closed
23 tasks
@codspeed-hq
Copy link

codspeed-hq bot commented May 31, 2024

CodSpeed Performance Report

Merging #11628 will improve performances by 28.24%

Comparing dhruv/remove-tok (ed22238) with main (685d11a)

Summary

⚡ 19 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark main dhruv/remove-tok Change
⚡ lexer[large/dataset.py] 1.4 ms 1.1 ms +27.64%
⚡ lexer[numpy/ctypeslib.py] 284.3 µs 225.8 µs +25.93%
⚡ lexer[numpy/globals.py] 36.7 µs 29.6 µs +24.09%
⚡ lexer[pydantic/types.py] 639.9 µs 502.9 µs +27.23%
⚡ lexer[unicode/pypinyin.py] 98.3 µs 76.6 µs +28.24%
⚡ linter/all-rules[large/dataset.py] 16.9 ms 15.9 ms +6.13%
⚡ linter/all-rules[numpy/ctypeslib.py] 4.1 ms 3.9 ms +5.44%
⚡ linter/all-rules[pydantic/types.py] 8.2 ms 7.7 ms +6.91%
⚡ linter/default-rules[large/dataset.py] 4.3 ms 3.7 ms +16.42%
⚡ linter/default-rules[numpy/ctypeslib.py] 1,013.7 µs 941.1 µs +7.71%
⚡ linter/default-rules[pydantic/types.py] 2.1 ms 1.9 ms +11.87%
⚡ linter/default-rules[unicode/pypinyin.py] 406 µs 359.7 µs +12.88%
⚡ linter/all-with-preview-rules[large/dataset.py] 20.3 ms 19.1 ms +6.08%
⚡ linter/all-with-preview-rules[pydantic/types.py] 10 ms 9.6 ms +4.25%
⚡ parser[large/dataset.py] 5.7 ms 5.2 ms +10.18%
⚡ parser[numpy/ctypeslib.py] 1,161.7 µs 991.4 µs +17.17%
⚡ parser[numpy/globals.py] 122.2 µs 105.8 µs +15.47%
⚡ parser[pydantic/types.py] 2.3 ms 2.2 ms +5.97%
⚡ parser[unicode/pypinyin.py] 371.3 µs 337.7 µs +9.93%

dhruvmanila added a commit that referenced this pull request May 31, 2024
@dhruvmanila
Remove Tok enum (#11628)
55149f9 
## Summary

This PR removes the `Tok` enum now that all of it's dependencies have
been updated to use `TokenKind` instead.

closes: #11401
dhruvmanila added a commit that referenced this pull request Jun 3, 2024
@dhruvmanila
Remove Tok enum (#11628)
f98019b 
## Summary

This PR removes the `Tok` enum now that all of it's dependencies have
been updated to use `TokenKind` instead.

closes: #11401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

Assignees

No one assigned

Labels

internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dhruvmanila