-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
trackingA "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues.A "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues.
Description
This issue is to keep track of all the tasks required to remove the Tok dependency from the downstream tools (linter and formatter).
Notes:
- Certain tasks might need to be clubbed with the parser changes
- The implementation logic for certain usages isn't finalized yet
Linter
- Move these rules to the AST checker:
-
PLE1300,PLE1307(Avoid lexer usage inPLE1300andPLE1307#11406) -
UP031 -
W605(MoveW605to the AST checker #11402)
-
-
doc_lines_from_tokens(UseTokenKindindoc_lines_from_tokens#11418) - Following rules can be updated to directly use
TokenKind(via AddTokensnewtype wrapper,TokenKinditerator #11361):-
COM812,COM818,COM819(Move most of token-based rules to useTokenKind#11420) -
E301..E306(blank line rules) (UseTokenKindin blank lines checker #11419) -
E701..E703(Move most of token-based rules to useTokenKind#11420) -
ISC001,ISC002(Move most of token-based rules to useTokenKind#11420) -
PLE2510,PLE2512..PLE2515(Move most of token-based rules to useTokenKind#11420) -
UP034(MoveUP034to useTokenKindinstead ofTok#11424) -
W391(Move most of token-based rules to useTokenKind#11420)
-
-
remove_import_membersuseslexmethod (Replace most usages oflex_starts_atwithTokens#11511) -
extract_noqa_line_foruses thekindinformation from the string token -
locate_cmp_opsuses thelexmethod (Replacelexusages #11562) -
tokens_and_rangesextracts the comment ranges from the token stream -
unsorted_dunder_allandunsorted_dunder_slotsextracts the value from the string token (Replace most usages oflex_starts_atwithTokens#11511) -
UP032uses thelex_starts_atmethod (Replace most usages oflex_starts_atwithTokens#11511) -
I001(trailing_comma) uses thelex_starts_atmethod (Replace most usages oflex_starts_atwithTokens#11511) -
Stylistextracts the indentation and quote information from the token (UpdateStylist,Indexerto use tokens from parsed output #11592) -
Indexerextracts trivia and string ranges, line continuation start value (UpdateStylist,Indexerto use tokens from parsed output #11592)
Formatter
- Move away from
lex_starts_atinwrite_suppressed_statements_starting_with_trailing_comment(Replacelex_starts_atwithTokensin the formatter #11515)
Internal document: https://www.notion.so/astral-sh/Downstream-work-items-551b86e104a34054b7192675550a6c25?pvs=4
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
trackingA "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues.A "meta" issue that tracks completion of a bigger task via a list of smaller scoped issues.