Fix: Add "preservePivots" condition when importing FBX animation#6115
Merged
kimkulling merged 3 commits intoassimp:masterfrom May 31, 2025
Merged
Fix: Add "preservePivots" condition when importing FBX animation#6115kimkulling merged 3 commits intoassimp:masterfrom
kimkulling merged 3 commits intoassimp:masterfrom
Conversation
|
This is very nice to be handled from inside assimp. Here is the same issue discussed - i have posted a workaround from outside. but it would be great if this is fixed in the library. |
Member
|
Merged, thanks a lot for your contibution. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
The animation importer part has no handling for the "preservePivots" setting.
This setting prevents dummy nodes when processing nodes in the model.
However, animations are not, so if you use this option, the animation will not work with the model.
See comments below.
https://github.com/assimp/assimp/blob/ac5988422a7f1898b25c13fb5fb068c646a4c544/code/AssetLib/FBX/FBXConverter.cpp#L2957C1-L2984C73
https://github.com/assimp/assimp/blob/ac5988422a7f1898b25c13fb5fb068c646a4c544/code/AssetLib/FBX/FBXConverter.cpp#L747C49-L747C51
GenerateTransformationNodeChainhttps://github.com/assimp/assimp/blob/ac5988422a7f1898b25c13fb5fb068c646a4c544/code/AssetLib/FBX/FBXConverter.cpp#L870C4-L875C1
*Note:
NameTransformationChainNodecreates dummy node names.