Add extra token for assembly assignment#6023
Merged
Conversation
ba90dbd to
bc09196
Compare
chriseth
reviewed
Feb 18, 2019
chriseth
reviewed
Feb 18, 2019
bc09196 to
a1012c6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6023 +/- ##
===========================================
- Coverage 88.37% 88.33% -0.05%
===========================================
Files 362 361 -1
Lines 34876 34877 +1
Branches 4136 4128 -8
===========================================
- Hits 30823 30809 -14
- Misses 2677 2694 +17
+ Partials 1376 1374 -2
|
a1012c6 to
280d9a4
Compare
Contributor
Author
|
Updated |
chriseth
reviewed
Feb 18, 2019
chriseth
reviewed
Feb 18, 2019
Contributor
|
I think this needs a changelog entry. |
axic
reviewed
Feb 18, 2019
280d9a4 to
ae08796
Compare
Contributor
Author
|
UpdateD |
ae08796 to
6b19c0a
Compare
Contributor
Author
|
Fixed failing test (forgot error msg update) |
chriseth
reviewed
Feb 19, 2019
3ac6580 to
f93f0e2
Compare
Contributor
Author
|
Contributor
Author
|
I forgot something and I'll try to fix the coverage, too |
f93f0e2 to
f493608
Compare
Contributor
Author
|
Okay, good to go now. |
chriseth
reviewed
Feb 20, 2019
chriseth
reviewed
Feb 20, 2019
f493608 to
341e1b1
Compare
Contributor
Author
|
Condensed the logic for the AssembylAssign / Comma syntax even more |
axic
suggested changes
Feb 21, 2019
Contributor
axic
left a comment
There was a problem hiding this comment.
Please add a test into libsolidity/SolidityScanner.cpp
chriseth
reviewed
Feb 21, 2019
Adding an extra token for := prevents whitespace between : = being valid
341e1b1 to
f395d5b
Compare
Contributor
Author
|
chriseth
approved these changes
Feb 21, 2019
axic
reviewed
Feb 21, 2019
|
|
||
| BOOST_AUTO_TEST_CASE(assembly_multiple_assign) | ||
| { | ||
| Scanner scanner(CharStream("let a, b, c := 1", "")); |
Contributor
There was a problem hiding this comment.
To be clear these supposed to test compounding similar characters and see if they are tokenised properly, such as:
::=, =:=, :=:=, etc.
github-merge-queue bot
pushed a commit
to NomicFoundation/slang
that referenced
this pull request
Feb 29, 2024
rollup-smithbm0p
added a commit
to rollup-smithbm0p/slang
that referenced
this pull request
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an extra token for := prevents whitespace between : = being valid
Fixes #4185