BinaryProtocolFactory and THRIFT-1382 fix#8
Closed
jimktrains wants to merge 2 commits intoapache:trunkfrom
Closed
Conversation
added 2 commits
October 31, 2011 09:15
Incorporates patch from J. Farrell found at https://issues.apache.org/jira/browse/THRIFT-1382
Contributor
|
Please see http://wiki.apache.org/thrift/HowToContribute for contributing patches back to Thrift. We currently do not accept patches back this way from github. |
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Oct 2, 2015
Sync completer
keynslug
pushed a commit
to keynslug/thrift
that referenced
this pull request
May 20, 2016
Add missing dockerfile instruction
degupta
pushed a commit
to degupta/thrift
that referenced
this pull request
Sep 23, 2016
…-fds Pull a couple of upstream bug fixes
rokaye
referenced
this pull request
May 12, 2017
…en validate compiler option is enabled Client: php This closes #1215
elprans
pushed a commit
to elprans/thrift
that referenced
this pull request
Jul 24, 2017
There are two leaks here, and this change addresses both of them.
1. PyUnicode_DecodeUTF8() returns a new reference, so we need to manage
its lifetime. We were previously discarding it by using it only in
the conditional check.
2. The Py_INCREF(value) call should happen just before we assign it to
`nval`. Otherwise, if we hit either of the UTF-8 failure cases and
return, we leak that additional reference.
GerHobbelt
pushed a commit
to GerHobbelt/thrift
that referenced
this pull request
May 10, 2024
…cess compiler/cpp/src/generate/t_go_generator: Dont Assume GetSuccess to return a nil-able value
GerHobbelt
pushed a commit
to GerHobbelt/thrift
that referenced
this pull request
May 27, 2024
* Add Linux ARM64 build and publication * Change build naming scheme * Don't use github.ref_name in Build * Change naming of publishing jobs * Rename os-name -> platform * Rename ARM.cmake to Linux-ARM64.cmake * Return original workflow and add conditions to release one * Attempt to fix non running jobs * Attempt to fix non running jobs * Update .github/workflows/build-and-upload-binaries-after-release.yaml Co-authored-by: Andrew Mayorov <encube.ul@gmail.com> * Attempt to fix cmake file location * Attempt to fix cmake file location * Attempt to fix cmake file location * Change filename to use with TARGETARCH in Dockerfile * Revert "Change filename to use with TARGETARCH in Dockerfile" This reverts commit 6edeca1. Co-authored-by: Andrew Mayorov <encube.ul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows strict reads and writes optionally in BinaryProtocolFactory. Useful when wanting to integrate with scribe.
Should be backwards compatible.