Instead of having a different return value for each and every exception,#7
Closed
caoimhechaos wants to merge 1 commit intoapache:trunkfrom
caoimhechaos:trunk
Closed
Instead of having a different return value for each and every exception,#7caoimhechaos wants to merge 1 commit intoapache:trunkfrom caoimhechaos:trunk
caoimhechaos wants to merge 1 commit intoapache:trunkfrom
caoimhechaos:trunk
Conversation
just return them all as err and provide easy methods to figure out if the exceptions have a certain type.
Contributor
|
Please see http://wiki.apache.org/thrift/HowToContribute for contributing patches back to Thrift. We currently do not accept patches back this way from github. |
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Oct 2, 2015
Add a Dart console-client to the tutorial
keynslug
pushed a commit
to keynslug/thrift
that referenced
this pull request
May 20, 2016
More refactoring and fixes for Erlang * Refactor unions, constants, filenaming * Refactor scoping for constants * Add 'scoped_typenames' and 'app_prefix' options * Fix number types validation for Erlang * Fix types generation for dialyzer * Kludge for providing transport data from thrift protocol object. * Refactor include and some other cases * Fix default struct value rendenring * Fix hardcoded default values * Fix erlang lib tests
keynslug
pushed a commit
to keynslug/thrift
that referenced
this pull request
Jun 17, 2016
More refactoring and fixes for Erlang * Refactor unions, constants, filenaming * Refactor scoping for constants * Add 'scoped_typenames' and 'app_prefix' options * Fix number types validation for Erlang * Fix types generation for dialyzer * Kludge for providing transport data from thrift protocol object. * Refactor include and some other cases * Fix default struct value rendenring * Fix hardcoded default values * Fix erlang lib tests
degupta
added a commit
to degupta/thrift
that referenced
this pull request
Sep 23, 2016
Get rid of Thrift in the page title and header.
rokaye
referenced
this pull request
May 12, 2017
…en validate compiler option is enabled Client: php This closes #1215
elprans
pushed a commit
to elprans/thrift
that referenced
this pull request
Jul 24, 2017
There are two leaks here, and this change addresses both of them.
1. PyUnicode_DecodeUTF8() returns a new reference, so we need to manage
its lifetime. We were previously discarding it by using it only in
the conditional check.
2. The Py_INCREF(value) call should happen just before we assign it to
`nval`. Otherwise, if we hit either of the UTF-8 failure cases and
return, we leak that additional reference.
GerHobbelt
pushed a commit
to GerHobbelt/thrift
that referenced
this pull request
May 10, 2024
lib/go/thrift: Allow TransportException to be unwrapped
GerHobbelt
pushed a commit
to GerHobbelt/thrift
that referenced
this pull request
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just return them all as err and provide easy methods to figure out if
the exceptions have a certain type.