[cleanup][broker] Remove unused configuration maxMessageSizeCheckIntervalInSeconds #24958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration `maxMessageSizeCheckIntervalInSeconds` was introduced in apache#11141. After the topic local cache was added (apache#12830), this configuration became obsolete and is now unused.
|
@Shawyeok Please add the following content to your PR description and select a checkbox: |
lhotari
approved these changes
Nov 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24958 +/- ##
============================================
+ Coverage 74.21% 74.26% +0.04%
- Complexity 33905 33914 +9
============================================
Files 1913 1913
Lines 149510 149510
Branches 17373 17373
============================================
+ Hits 110965 111039 +74
+ Misses 29692 29639 -53
+ Partials 8853 8832 -21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…rvalInSeconds (apache#24958) (cherry picked from commit d9a36b2) (cherry picked from commit 3f00a00)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 14, 2025
…rvalInSeconds (apache#24958) (cherry picked from commit d9a36b2) (cherry picked from commit 3f00a00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The configuration
maxMessageSizeCheckIntervalInSecondswas introduced in #11141. After the topic local cache was added (#12830), this configuration became obsolete and is now unused.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: