add parameter to control publish message check policy frequency #11141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymitaet
reviewed
Jun 29, 2021
Member
Anonymitaet
left a comment
There was a problem hiding this comment.
@hangc0276 thanks for your contribution! I've left a comment, PTAL.
Besides, need to add the descriptions to docs (https://pulsar.apache.org/docs/en/next/reference-configuration/)?
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
sijie
approved these changes
Jul 14, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…he#11141) ### Motivation In current `isExceedMaximumMessageSize` implementation, it get topic policy and compare maxMessageSize value. However, for each message to publish, it should call isExceedMaximumMessageSize once, which cost too much resources. ### Modifiction 1. add `maxMessageSizeCheckIntervalInSeconds` parameter to control maxMessageSize refresh frequency 2. reduce getTopicPolicies call frequency to reduce resources cost. 3. add test to cover this case.
Shawyeok
added a commit
to Shawyeok/pulsar
that referenced
this pull request
Nov 7, 2025
The configuration `maxMessageSizeCheckIntervalInSeconds` was introduced in apache#11141. After the topic local cache was added (apache#12830), this configuration became obsolete and is now unused.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In current
isExceedMaximumMessageSizeimplementation, it get topic policy and compare maxMessageSize value.However, for each message to publish, it should call isExceedMaximumMessageSize once, which cost too much resources.
Modifiction
maxMessageSizeCheckIntervalInSecondsparameter to control maxMessageSize refresh frequency