[fix][client] Make auto partitions update work for old brokers without PIP-344 #24822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Oct 7, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing this
Member
|
There seems to be a test that explicitly tests for the behavior that connecting to an older broker fails: This test was added in #22773 and it seems to test what is defined in PIP-344 Backward and Forward compatibility:
@poorbarcode would it be possible to explain the reason why the client should fail in this case? |
Contributor
Author
|
I think it has been explained in #23136. I updated the test and the PIP document now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24822 +/- ##
============================================
- Coverage 74.42% 74.29% -0.13%
- Complexity 33488 33801 +313
============================================
Files 1912 1912
Lines 149077 149089 +12
Branches 17300 17300
============================================
- Hits 110950 110769 -181
- Misses 29331 29482 +151
- Partials 8796 8838 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…t PIP-344 (apache#24822) (cherry picked from commit 5e59d0e) (cherry picked from commit 708feff)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…t PIP-344 (apache#24822) (cherry picked from commit 5e59d0e) (cherry picked from commit 6da23ff)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 30, 2025
…t PIP-344 (apache#24822) (cherry picked from commit 5e59d0e) (cherry picked from commit 708feff)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…t PIP-344 (apache#24822) (cherry picked from commit 5e59d0e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…t PIP-344 (apache#24822) (cherry picked from commit 5e59d0e) (cherry picked from commit 6da23ff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://lists.apache.org/thread/tpd2kgl4v3x8bkw0skv0nj38rzrk56t7
Modifications
Set the 3rd argument of
getPartitionedTopicMetadatatotrueinPulsarClientImpl#getPartitionsForTopic, which is used to query the number of partitions.Add
testAutoPartitionsUpdateto cover the case. Specially, it tests a consumer that subscribes two partitioned topics to cover the path here:pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Line 182 in 008e4eb
P.S. This test is only added to
ClientTest25, which runs tests againstapachepulsar/pulsar:2.5.0image. The current backward compatibility test strategy is ambiguous that only 2.2.0, 2.3.0, 2.4.0, 2.5.0 are tested. It's hard to cover all old versions, but only choose these 4 versions does not make sense. This topic should be out of the scope of this PR. Anyway, the test on 2.5.0 can already prevent regression on the fix.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: