[improve] [client] PIP-344 support feature flag supportsGetPartitionedMetadataWithoutAutoCreation #22773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 31, 2024
Contributor
codelipenghui
left a comment
There was a problem hiding this comment.
LGTM, just left a minor comment.
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot rerun-failure-checks |
RobertIndie
approved these changes
May 31, 2024
Contributor
Author
|
/pulsarbot rerun-failure-checks |
…dMetadataWithoutAutoCreation
3102635 to
2136979
Compare
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…dMetadataWithoutAutoCreation (apache#22773)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 18, 2025
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 18, 2025
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)
Section Backward & Forward Compatibility
Old version client and New version Broker: The client will call the old API.
New version client and Old version Broker: The feature flag
supports_binary_api_get_partitioned_meta_with_param_created_falsewill befalse. The client will get a not-support error if the paramcreateIfAutoCreationEnabledisfalse.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x