[fix][broker]Fix flaky test PartitionCreationTest.testCreateMissedPartitions #24679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lhotari
approved these changes
Aug 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24679 +/- ##
=============================================
+ Coverage 38.55% 74.16% +35.60%
- Complexity 12898 32991 +20093
=============================================
Files 1828 1893 +65
Lines 142888 147772 +4884
Branches 16456 17089 +633
=============================================
+ Hits 55097 109600 +54503
+ Misses 80299 29413 -50886
- Partials 7492 8759 +1267
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 1, 2025
…titions (apache#24679) (cherry picked from commit f795bf8) (cherry picked from commit 8c56b71)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Sep 10, 2025
…titions (apache#24679) (cherry picked from commit f795bf8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…titions (apache#24679) (cherry picked from commit f795bf8) (cherry picked from commit 8c56b71)
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Sep 12, 2025
…titions (apache#24679) (cherry picked from commit f795bf8)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#24651 changed the behaviour, which allows creating partitions if the partitioned topic metadata exists. Then the test
PartitionCreationTest.testCreateMissedPartitionsis not suitable anymore.It can pass when merging #24651 because the test has another issue: it calls
createPartitionedTopicAsync, but never waits for it to be finished, which leads to the next check passing because the creation may not have completed.Modifications
Improve the test
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x