[fix][broker]Failed to create partitions after the partitions were deleted because topic GC #24651
+81
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested changes
Aug 22, 2025
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
e4f7c20 to
97c024c
Compare
codelipenghui
approved these changes
Aug 26, 2025
Contributor
|
/pulsarbot run-failure-checks |
coderzc
approved these changes
Aug 27, 2025
Member
|
@poorbarcode Please fix code style issue. |
…leted because topic GC
635b6d4 to
e11f75e
Compare
Contributor
Author
|
I changed the test that you added: Please take a look |
nodece
reviewed
Aug 27, 2025
...roker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
Show resolved
Hide resolved
nodece
approved these changes
Aug 27, 2025
Member
nodece
left a comment
There was a problem hiding this comment.
Overall LGTM.
This is an important change because it allows partition recreation when allowAutoTopicCreation=false and partitioned metadata exists.
To clarify this behavior, I recommend updating the Javadoc for allowAutoTopicCreation to reflect this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24651 +/- ##
=========================================
Coverage 74.26% 74.26%
- Complexity 33200 33220 +20
=========================================
Files 1885 1885
Lines 146953 146969 +16
Branches 16928 16931 +3
=========================================
+ Hits 109129 109146 +17
- Misses 29104 29134 +30
+ Partials 8720 8689 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2025
…leted because topic GC (apache#24651) (cherry picked from commit 7c57683) (cherry picked from commit eef82db)
4 tasks
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Sep 10, 2025
…leted because topic GC (apache#24651) (cherry picked from commit 7c57683)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…leted because topic GC (apache#24651) (cherry picked from commit 7c57683) (cherry picked from commit eef82db)
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Sep 12, 2025
…leted because topic GC (apache#24651) (cherry picked from commit 7c57683)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…leted because topic GC (apache#24651)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…leted because topic GC (apache#24651)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Configurations:
allowAutoTopicCreation:falsebrokerDeleteInactiveTopicsEnabled:truebrokerDeleteInactivePartitionedTopicMetadataEnabled:falseSteps of the issue occurred
2partitions.partition-0is deleted because of no backlog.TopicNotFoundExpection.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x