[fix][broker]User topic failed to delete after removed cluster because of failed delete data from transaction buffer topic #24648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot rerun-failure-checks |
coderzc
reviewed
Aug 28, 2025
...roker/src/main/java/org/apache/pulsar/broker/systopic/NamespaceEventsSystemTopicFactory.java
Outdated
Show resolved
Hide resolved
0fbc09c to
b74b510
Compare
Contributor
Author
|
The test |
…e transaction buffer can not be accessed
b74b510 to
d3d49f2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #24648 +/- ##
=============================================
+ Coverage 38.72% 74.14% +35.42%
- Complexity 13076 33375 +20299
=============================================
Files 1836 1893 +57
Lines 143697 147811 +4114
Branches 16616 17098 +482
=============================================
+ Hits 55650 109598 +53948
+ Misses 80600 29450 -51150
- Partials 7447 8763 +1316
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
Aug 29, 2025
Technoboy-
pushed a commit
that referenced
this pull request
Sep 10, 2025
…e of failed delete data from transaction buffer topic (#24648)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…e of failed delete data from transaction buffer topic (apache#24648) (cherry picked from commit 5f1c540)
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Sep 12, 2025
…e of failed delete data from transaction buffer topic (apache#24648)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…e of failed delete data from transaction buffer topic (apache#24648) (cherry picked from commit 5f1c540)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…e of failed delete data from transaction buffer topic (apache#24648)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…e of failed delete data from transaction buffer topic (apache#24648)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
namespace-level replicatedClustersdelete data from transaction buffercan not be executed successfully anymore, and will get an error "Namespace missing local cluster name in clusters list". Because the topic__transaction_buffer_snapshotcan not be accessed anymore since the cluster was removed.topic.checkReplicationand other operations will retry again and again, as a result, the broker will crash of OOMModifications
__transaction_buffer_snapshotif it is not allowed to be accessed(removed current cluster fromallowed cluster)__transaction_buffer_snapshothas been deleted.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x