-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 #24263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pulsar doesn't seem to package zstd-jni in the Pulsar distribution directly since the LICENSE files didn't require an update. I guess this library is used by some Pulsar IO connector? |
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although this has a minor impact on Pulsar (not included in Pulsar distribution's main libraries)
|
/pulsarbot run-failure-checks |
@StevenLuMT Pulsar CI is currently broken. SchemaTest.testPendingQueueSizeIfIncompatible fails consistently. I'm disabling that in #24261 |
Got it,Thanks @lhotari |
|
I think it's probably not used anymore, since we switched to java implementation of ZStd few years ago |
@merlimat Good suggestion. I think zstd-jni can be explained and upgraded. But to solve the fundamental problem, I will submit a PR for commons-compress
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24263 +/- ##
============================================
+ Coverage 73.57% 74.26% +0.69%
+ Complexity 32624 32611 -13
============================================
Files 1877 1866 -11
Lines 139502 145048 +5546
Branches 15299 16579 +1280
============================================
+ Hits 102638 107727 +5089
+ Misses 28908 28798 -110
- Partials 7956 8523 +567
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34)
### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34)
### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit a868339)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit 6b762c2)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit a868339)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit 6b762c2)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit 6b762c2)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit 6b762c2)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit a868339)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit 6b762c2)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34) (cherry picked from commit a868339)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3 (cherry picked from commit 8289e34)
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3
…#24263) ### Motivation [zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements: 1. Enhanced Compression Speed for Small Data Blocks 2. Substantial --patch-from improvements 3. Compression ratio improvements for large files 4. Command-Line Interface Updates See release notes for details: - [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7) - [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3) ### Modifications Upgrade zstd version from 1.5.2-3 to 1.5.7-3

Motivation
zstd would be useful to have zstd upgraded to latest version,the new version brings many improvements:
See release notes for details:
Modifications
Upgrade zstd version from 1.5.2-3 to 1.5.7-3
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
Check the box below or label this PR directly.
Need to update docs?
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: StevenLuMT#12