Skip to content

Conversation

@StevenLuMT
Copy link
Member

@StevenLuMT StevenLuMT commented May 7, 2025

Motivation

zstd would be useful to have zstd upgraded to latest version,the new version brings many improvements:

  1. Enhanced Compression Speed for Small Data Blocks
  2. Substantial --patch-from improvements
  3. Compression ratio improvements for large files
  4. Command-Line Interface Updates

See release notes for details:

Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: StevenLuMT#12

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 7, 2025
@liangyepianzhou liangyepianzhou requested a review from lhotari May 7, 2025 06:54
@liangyepianzhou liangyepianzhou added this to the 4.1.0 milestone May 7, 2025
@lhotari
Copy link
Member

lhotari commented May 7, 2025

Pulsar doesn't seem to package zstd-jni in the Pulsar distribution directly since the LICENSE files didn't require an update. I guess this library is used by some Pulsar IO connector?

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this has a minor impact on Pulsar (not included in Pulsar distribution's main libraries)

@StevenLuMT
Copy link
Member Author

/pulsarbot run-failure-checks

@lhotari
Copy link
Member

lhotari commented May 7, 2025

/pulsarbot run-failure-checks

@StevenLuMT Pulsar CI is currently broken. SchemaTest.testPendingQueueSizeIfIncompatible fails consistently. I'm disabling that in #24261

@StevenLuMT
Copy link
Member Author

StevenLuMT commented May 7, 2025

/pulsarbot run-failure-checks

@StevenLuMT Pulsar CI is currently broken. SchemaTest.testPendingQueueSizeIfIncompatible fails consistently. I'm disabling that in #24261

Got it,Thanks @lhotari

@merlimat
Copy link
Contributor

merlimat commented May 7, 2025

I think it's probably not used anymore, since we switched to java implementation of ZStd few years ago

@StevenLuMT
Copy link
Member Author

StevenLuMT commented May 8, 2025

I think it's probably not used anymore, since we switched to java implementation of ZStd few years ago

@merlimat Good suggestion. I think zstd-jni can be explained and upgraded. But to solve the fundamental problem, I will submit a PR for commons-compress

image

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (bbc6224) to head (cc73410).
Report is 1088 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24263      +/-   ##
============================================
+ Coverage     73.57%   74.26%   +0.69%     
+ Complexity    32624    32611      -13     
============================================
  Files          1877     1866      -11     
  Lines        139502   145048    +5546     
  Branches      15299    16579    +1280     
============================================
+ Hits         102638   107727    +5089     
+ Misses        28908    28798     -110     
- Partials       7956     8523     +567     
Flag Coverage Δ
inttests 26.82% <ø> (+2.24%) ⬆️
systests 23.29% <ø> (-1.04%) ⬇️
unittests 73.75% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1082 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liangyepianzhou liangyepianzhou merged commit 8289e34 into apache:master May 9, 2025
51 of 52 checks passed
lhotari pushed a commit that referenced this pull request May 9, 2025
### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
lhotari pushed a commit that referenced this pull request May 9, 2025
### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
lhotari pushed a commit that referenced this pull request May 9, 2025
### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit a868339)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit 6b762c2)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit a868339)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit 6b762c2)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit 6b762c2)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit 6b762c2)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit a868339)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit 6b762c2)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
(cherry picked from commit a868339)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 28, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3

(cherry picked from commit 8289e34)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
…#24263)

### Motivation

[zstd](https://github.com/facebook/zstd/releases/tag/v1.5.7) would be useful to have zstd upgraded to latest version,the new version brings many improvements:
1. Enhanced Compression Speed for Small Data Blocks
2. Substantial --patch-from improvements
3. Compression ratio improvements for large files
4. Command-Line Interface Updates

See release notes for details:
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)

### Modifications

Upgrade zstd version from 1.5.2-3 to 1.5.7-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants