Skip to content

Conversation

@StevenLuMT
Copy link
Member

@StevenLuMT StevenLuMT commented May 8, 2025

Background

There are some issues with the version upgrade of commons-compress in the Pulsar and BookKeeper projects:

  1. Upgrade Apache Commons libraries to compatible versions bookkeeper#4582 there are some issues with the Changes description of your PR, upgrade commons-compress from 1.26.0 to 1.27.1, not 1.27.0, I think the Changes can be modified

  2. [improve] Upgrade Apache Commons library versions to compatible versions #24205 The version number is wrong,I have proposed a new fix [improve][build] Upgrade commons-compress version from 1.27.0 to 1.27.1 #24270 Please help review it

Motivation

commons-compress would be useful to upgrade to latest version,the new version brings improvements:

  1. Compression into BZip2 format has unexpected end of file when using a BufferedOutputStream. Fixes COMPRESS-686.

See release notes for details:

image

Modifications

Upgrade commons-compress version from 1.27.0 to 1.27.1

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: StevenLuMT#13

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23%. Comparing base (bbc6224) to head (a06f6d6).
Report is 1085 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24270      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.66%     
+ Complexity    32624    32218     -406     
============================================
  Files          1877     1866      -11     
  Lines        139502   145048    +5546     
  Branches      15299    16579    +1280     
============================================
+ Hits         102638   107682    +5044     
+ Misses        28908    28841      -67     
- Partials       7956     8525     +569     
Flag Coverage Δ
inttests 26.78% <ø> (+2.19%) ⬆️
systests 23.28% <ø> (-1.04%) ⬇️
unittests 73.71% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1084 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dao-jun dao-jun merged commit 0b00525 into apache:master May 8, 2025
57 of 58 checks passed
lhotari pushed a commit that referenced this pull request May 9, 2025
lhotari pushed a commit that referenced this pull request May 9, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
….1 (apache#24270)

(cherry picked from commit 0b00525)
(cherry picked from commit 2e2d32a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
….1 (apache#24270)

(cherry picked from commit 0b00525)
(cherry picked from commit 2e2d32a)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
….1 (apache#24270)

(cherry picked from commit 0b00525)
(cherry picked from commit 2e2d32a)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants