[fix][build] Fix docker image building by replacing deprecated and removed compress argument #24155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved compress argument
BewareMyPower
approved these changes
Apr 7, 2025
dao-jun
approved these changes
Apr 7, 2025
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2025
…moved compress argument (apache#24155) (cherry picked from commit 2759eaf) (cherry picked from commit 3454851)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2025
…moved compress argument (apache#24155) (cherry picked from commit 2759eaf) (cherry picked from commit 3454851)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…moved compress argument (apache#24155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Building docker images have started to fail due to the use of a deprecated
--compress zip-9argument forjlink.This parameter was deprecated in Java 16. It seems that the removal was delayed and now master branch is broken with most recent Corretto 21 and 17 JDK versions (Corretto-21.0.6.7.1 and also Corretto-17.0.14.7.1).
Valid
jlinkcompress argument options:The replacement for
--compress zip-9is--compress=2(zip).Modifications
Replace
--compress zip-9with--compress=2Documentation
docdoc-requireddoc-not-neededdoc-complete