[fix][broker] Directly query single topic existence when the topic is partitioned #24154

nodece · 2025-04-07T08:22:27Z

Motivation

#24118 breaks checkTopicExists. The topic metadata exists, but the topic may not exist.

~~These changes are already covered by org.apache.pulsar.broker.namespace.NamespaceServiceTest. However, since this test belongs to the flaky test group, regressions might not be reliably caught.~~

Modifications

Directly query single topic existence when the topic is partitioned.
Use NotFoundException instead of TopicDoesNotExistException that is introduced by [fix][broker] Add topic consistency check #24118.

Documentation

doc
doc-required
doc-not-needed
doc-complete

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:1428

Ensure that the new direct query for single topic existence is fully covered by unit tests, particularly verifying that checkNonPartitionedTopicExists returns the correct TopicExistsInfo when the topic is partitioned.

return checkNonPartitionedTopicExists(topic).thenApply(

lhotari · 2025-04-07T09:29:29Z

These changes are already covered by org.apache.pulsar.broker.namespace.NamespaceServiceTest. However, since this test belongs to the flaky test group, regressions might not be reliably caught.

@nodece Did some test fail in NamespaceServiceTest? I ran that test class on master branch and there aren't any failures.

lhotari

Add a test that explicitly tests the correct behavior.

pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java

nodece · 2025-04-07T09:41:18Z

These changes are already covered by org.apache.pulsar.broker.namespace.NamespaceServiceTest. However, since this test belongs to the flaky test group, regressions might not be reliably caught.

@nodece Did some test fail in NamespaceServiceTest? I ran that test class on master branch and there aren't any failures.

Sorry, my local code may be incorrect, so I saw the test fail.

lhotari · 2025-04-07T10:02:32Z

There are 2 test failures in master which I've had to disable while getting Pulsar CI operational in #24155:
75b5b9f

Please rebase this PR on top of those changes. It could be done before PR #24155 is merged so that you can already start preparing the changes.

git fetch origin pull/24155/head
git rebase FETCH_HEAD

After PR 24155 has been merged, you can rebase again to cleanup the commits in your PR branch.

nodece · 2025-04-07T11:56:34Z

/pulsarbot rerun-failure-checks

lhotari · 2025-04-07T12:55:55Z

@nodece Now that #24155 has been merged, please rebase

… partitioned Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nodece · 2025-04-07T13:38:35Z

@lhotari Rebase is done, please review.

lhotari · 2025-04-07T13:52:44Z

@nodece I'll review. #24118 and this PR doesn't have any release labels? are these PRs only for 4.1.x?

pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java

nodece · 2025-04-07T13:58:24Z

@nodece I'll review. #24118 and this PR doesn't have any release labels? are these PRs only for 4.1.x?

Yes.

I think it would be helpful to start a discussion on the dev mailing list regarding the feedback in this comment.

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

…topic is partitioned (#24154)" This reverts commit ee6e84f.

…topic is partitioned (#24154)" This reverts commit 6713265.

lhotari · 2025-04-23T11:15:52Z

Reverted from branch-3.0, branch-3.3 and branch-4.0 as per this dev mailing list message.

…ectly removed by apache#24154

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0d6c6f4) (cherry picked from commit ee6e84f)

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0d6c6f4) (cherry picked from commit ee6e84f)

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0d6c6f4) (cherry picked from commit ee6e84f)

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0d6c6f4) (cherry picked from commit b619f9c)

…topic is partitioned (apache#24154)" This reverts commit b619f9c. (cherry picked from commit d6f17d0)

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0d6c6f4) (cherry picked from commit b619f9c)

…topic is partitioned (apache#24154)" This reverts commit b619f9c. (cherry picked from commit d6f17d0)

…topic is partitioned (apache#24154)" This reverts commit b619f9c.

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nodece added the ready-to-test label Apr 7, 2025

nodece requested review from Copilot, dao-jun, lhotari, poorbarcode and shibd April 7, 2025 08:22

Copilot AI reviewed Apr 7, 2025

View reviewed changes

github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 7, 2025

nodece force-pushed the fix-checkTopicExists branch from cf656b1 to 43597f3 Compare April 7, 2025 08:53

dao-jun approved these changes Apr 7, 2025

View reviewed changes

nodece added this to the 4.1.0 milestone Apr 7, 2025

nodece force-pushed the fix-checkTopicExists branch from 43597f3 to ab19595 Compare April 7, 2025 09:23

lhotari requested changes Apr 7, 2025

View reviewed changes

pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java Show resolved Hide resolved

lhotari mentioned this pull request Apr 7, 2025

[fix][build] Fix docker image building by replacing deprecated and removed compress argument #24155

Merged

4 tasks

nodece force-pushed the fix-checkTopicExists branch 2 times, most recently from 468e168 to 640ddf3 Compare April 7, 2025 10:36

nodece requested a review from lhotari April 7, 2025 11:39

[fix][broker] Directly query single topic existence when the topic is…

905b19a

… partitioned Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nodece force-pushed the fix-checkTopicExists branch from 640ddf3 to 905b19a Compare April 7, 2025 13:34

lhotari reviewed Apr 7, 2025

View reviewed changes

pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java Outdated Show resolved Hide resolved

Use satisfies instead of matches

8a5c6a4

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nodece requested a review from lhotari April 7, 2025 14:10

lhotari added a commit that referenced this pull request Apr 23, 2025

Revert "[fix][broker] Directly query single topic existence when the …

204d8fc

…topic is partitioned (#24154)" This reverts commit ee6e84f.

lhotari added a commit that referenced this pull request Apr 23, 2025

Revert "[fix][broker] Directly query single topic existence when the …

983161a

…topic is partitioned (#24154)" This reverts commit 6713265.

lhotari mentioned this pull request Apr 23, 2025

[fix][broker] Add validatePartitionMetadataConsistency to fix the regression #24195

Closed

14 tasks

lhotari removed cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 release/3.0.12 release/3.3.7 release/4.0.5 labels Apr 23, 2025

poorbarcode added a commit to poorbarcode/pulsar that referenced this pull request Apr 24, 2025

[improve][broker]Add back the test testCheckTopicExists, which incorr…

84d20b5

…ectly removed by apache#24154

poorbarcode mentioned this pull request Apr 24, 2025

[improve][broker]Add back the test testCheckTopicExists, which incorrectly removed #24208

Closed

4 tasks

manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 27, 2025

Revert "[fix][broker] Directly query single topic existence when the …

e563ce6

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

nodece mentioned this pull request Apr 28, 2025

[fix][broker] Allow recreation of partitioned topic after metadata loss #24225

Merged

4 tasks

ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 30, 2025

Revert "[fix][broker] Directly query single topic existence when the …

a2e9cf3

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request May 1, 2025

Revert "[fix][broker] Directly query single topic existence when the …

f40178f

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request May 1, 2025

Revert "[fix][broker] Directly query single topic existence when the …

206e7a9

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 2, 2025

Revert "[fix][broker] Directly query single topic existence when the …

a4bc50b

…topic is partitioned (apache#24154)" This reverts commit ee6e84f. (cherry picked from commit 204d8fc)

manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 2, 2025

Revert "[fix][broker] Directly query single topic existence when the …

be075b0

…topic is partitioned (apache#24154)" This reverts commit b619f9c. (cherry picked from commit d6f17d0)

srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 6, 2025

Revert "[fix][broker] Directly query single topic existence when the …

a169bc4

…topic is partitioned (apache#24154)" This reverts commit b619f9c. (cherry picked from commit d6f17d0)

lhotari mentioned this pull request May 16, 2025

[fix][broker]Global topic policies do not affect after unloading topic and persistence global topic policies never affect #24279

Merged

4 tasks

nborisov pushed a commit to nborisov/pulsar that referenced this pull request Sep 12, 2025

Revert "[fix][broker] Directly query single topic existence when the …

54293f6

…topic is partitioned (apache#24154)" This reverts commit b619f9c.

walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025

[fix][broker] Directly query single topic existence when the topic is…

9610d99

… partitioned (apache#24154) Signed-off-by: Zixuan Liu <nodeces@gmail.com>

[fix][broker] Directly query single topic existence when the topic is partitioned #24154

[fix][broker] Directly query single topic existence when the topic is partitioned #24154

Uh oh!

Conversation

nodece commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Documentation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

lhotari commented Apr 7, 2025

Uh oh!

lhotari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodece commented Apr 7, 2025

Uh oh!

lhotari commented Apr 7, 2025

Uh oh!

nodece commented Apr 7, 2025

Uh oh!

lhotari commented Apr 7, 2025

Uh oh!

nodece commented Apr 7, 2025

Uh oh!

lhotari commented Apr 7, 2025

Uh oh!

Uh oh!

nodece commented Apr 7, 2025

Uh oh!

lhotari commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nodece commented Apr 7, 2025 •

edited

Loading