[fix][client] Fix ArrayIndexOutOfBoundsException when using SameAuthParamsLookupAutoClusterFailover #23336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any chance to add a test case? |
Technoboy-
approved these changes
Sep 24, 2024
Member
@poorbarcode @Technoboy- any chance to handle this? |
lhotari
reviewed
Oct 30, 2024
...ent/src/main/java/org/apache/pulsar/client/impl/SameAuthParamsLookupAutoClusterFailover.java
Show resolved
Hide resolved
Member
|
@poorbarcode Do you have a chance to follow up on the review comment? |
Contributor
Author
Answered here: #23336 (comment) |
…kupAutoClusterFailover
8057c39 to
471669d
Compare
Contributor
Author
|
Rebase master |
dao-jun
approved these changes
Dec 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23336 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.80%
- Complexity 32624 35036 +2412
============================================
Files 1877 1944 +67
Lines 139502 147334 +7832
Branches 15299 16258 +959
============================================
+ Hits 102638 109583 +6945
- Misses 28908 29286 +378
- Partials 7956 8465 +509
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
Seems that #24662 was related. |
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 8, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Sep 10, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 11, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5) (cherry picked from commit 3552cd9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5) (cherry picked from commit 3552cd9)
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Sep 12, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 15, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5) (cherry picked from commit 8214bfd)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 15, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5) (cherry picked from commit 8214bfd)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 15, 2025
…aramsLookupAutoClusterFailover (apache#23336) (cherry picked from commit 8fd5bf5) (cherry picked from commit 8214bfd)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…aramsLookupAutoClusterFailover (apache#23336)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…aramsLookupAutoClusterFailover (apache#23336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a mistake in
SameAuthParamsLookupAutoClusterFailover.class, which may cause aArrayIndexOutOfBoundsException, but it affects nothing because it only happens when no server is available.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x