-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][client] fix ArrayIndexOutOfBoundsException in SameAuthParamsLookupAutoClusterFailover #24662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…AutoClusterFailover apache#24526
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for fixing @pmupkin. I renamed the title since this fixes a production code issue.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24662 +/- ##
============================================
+ Coverage 74.29% 74.31% +0.02%
- Complexity 33173 33188 +15
============================================
Files 1882 1884 +2
Lines 146854 146913 +59
Branches 16866 16874 +8
============================================
+ Hits 109105 109185 +80
+ Misses 29078 29054 -24
- Partials 8671 8674 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58)
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58) (cherry picked from commit c966506)
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58) (cherry picked from commit 41a9f2f)
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58) (cherry picked from commit 41a9f2f)
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58)
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58) (cherry picked from commit c966506)
…kupAutoClusterFailover (apache#24662) (cherry picked from commit 95dcb58)
…kupAutoClusterFailover (apache#24662)
…kupAutoClusterFailover (apache#24662)
Fixes #24526
Motivation
As reported in issue #24526, this is a flaky test caused by an array index out of bounds exception in findFailoverTo(), which leads to the failover logic failing. As a result, the test conditions can never be met, eventually causing a timeout.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: