[fix] Reapply shell script parameter passthrough fix #22867 reverted in #22921 #22923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrough syntax (apache#22867)" (apache#22921)" This reverts commit fa74538.
Member
Author
|
I hope we get the scripts fixed, at least for master branch. It's clearly a problem to use |
15 tasks
Contributor
|
Technoboy-
approved these changes
Oct 9, 2024
nodece
approved these changes
Oct 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22923 +/- ##
============================================
+ Coverage 73.57% 74.32% +0.75%
- Complexity 32624 34350 +1726
============================================
Files 1877 1949 +72
Lines 139502 146867 +7365
Branches 15299 16168 +869
============================================
+ Hits 102638 109160 +6522
- Misses 28908 29284 +376
- Partials 7956 8423 +467
Flags with carried forward coverage won't be shown. Click here to find out more. |
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fa74538.
Motivation
#22921 reverted the change in #22867 to use correct way of passing parameters in shell scripts.
The correct syntax is
"$@".In #22921, the argumentation was that a command
bin/pulsar zookeeper-shell --run-once "ls /ledgers"no longer works.This type of command has always been invalid for 2 reasons:
bin/pulsar zookeeper-shellhas never supported--run-onceparameter.zk-shellwhich supports this syntax.bin/pulsar zookeeper-shelldoesn't usezk-shellunder the covers.bin/pulsar zookeeper-shellhas never supported quoting the arguments to the command. This happened to work because of invalid parameter passing which is fixed by [fix][cli] Fix the shell script parameter passthrough syntax #22867zk-shellrequires the--run-once "ls /path"syntax.bin/pulsar zookeeper-shelldoesn't usezk-shellunder the covers.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete