Skip to content

[fix][cli] Fix the shell script parameter passthrough syntax #22867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 1 commit into from
Jun 7, 2024
Merged

[fix][cli] Fix the shell script parameter passthrough syntax #22867

lhotari merged 1 commit into from
Jun 7, 2024

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jun 7, 2024

Motivation

Modifications

  • replace $@ with "$@" in bin/pulsar and bin/bookkeeper

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
[fix][cli] Fix the shell script parameter passthrough syntax
3e8d8a1 
- parameters with whitespaces won't be properly passed through to the actual command unless
  "$@" is used (instead of $@ without double quotes.
- fixes shellcheck warning https://github.com/koalaman/shellcheck/wiki/SC2068
@lhotari lhotari added this to the 3.4.0 milestone Jun 7, 2024
@lhotari lhotari self-assigned this Jun 7, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 7, 2024
@lhotari lhotari merged commit c81c0f6 into apache:master Jun 7, 2024
lhotari added a commit that referenced this pull request Jun 7, 2024
@lhotari
[fix][cli] Fix the shell script parameter passthrough syntax (#22867)
cb0a211 
(cherry picked from commit c81c0f6)
lhotari added a commit that referenced this pull request Jun 10, 2024
@lhotari
[fix][cli] Fix the shell script parameter passthrough syntax (#22867)
a7cb5ec 
(cherry picked from commit c81c0f6)
lhotari added a commit that referenced this pull request Jun 10, 2024
@lhotari
[fix][cli] Fix the shell script parameter passthrough syntax (#22867)
ce9f15f 
(cherry picked from commit c81c0f6)
@coderzc coderzc mentioned this pull request Jun 14, 2024
Merged
15 tasks
coderzc added a commit to coderzc/pulsar that referenced this pull request Jun 17, 2024
@coderzc
Revert "[fix][cli] Fix the shell script parameter passthrough syntax (a…
b3b5378 
…pache#22867)"

This reverts commit c81c0f6.
@coderzc coderzc mentioned this pull request Jun 17, 2024
Merged
15 tasks
coderzc added a commit that referenced this pull request Jun 17, 2024
@coderzc
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough s…
fa74538 
…yntax (#22867)" (#22921)
coderzc added a commit that referenced this pull request Jun 17, 2024
@coderzc
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough s…
9a589bb 
…yntax (#22867)" (#22921)

(cherry picked from commit fa74538)
coderzc added a commit that referenced this pull request Jun 17, 2024
@coderzc
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough s…
59fa1a3 
…yntax (#22867)" (#22921)

(cherry picked from commit fa74538)
coderzc added a commit that referenced this pull request Jun 17, 2024
@coderzc
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough s…
c7e373a 
…yntax (#22867)" (#22921)

(cherry picked from commit fa74538)
lhotari added a commit to lhotari/pulsar that referenced this pull request Jun 17, 2024
@lhotari
Revert "[fix] Revert "[fix][cli] Fix the shell script parameter passt…
28a69ee 
…hrough syntax (apache#22867)" (apache#22921)"

This reverts commit fa74538.
@lhotari lhotari mentioned this pull request Jun 17, 2024
Merged
4 tasks
lhotari added a commit that referenced this pull request Oct 9, 2024
@lhotari
[fix] Reapply shell script parameter passthrough fix #22867 reverted in
b051dcd 
#22921 (#22923)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@lhotari @hanmz
[fix][cli] Fix the shell script parameter passthrough syntax (apache#…
bf548f2 
…22867)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@coderzc @hanmz
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough s…
ab50098 
…yntax (apache#22867)" (apache#22921)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@lhotari @hanmz
[fix] Reapply shell script parameter passthrough fix apache#22867 rev…
a0ab6bb 
…erted in apache#22921 (apache#22923)
bahetimansi pushed a commit to bahetimansi/pulsar that referenced this pull request Mar 23, 2025
@lhotari @bahetimansi
[fix][cli] Fix the shell script parameter passthrough syntax (apache#…
c5cbc86 
…22867)

(cherry picked from commit c81c0f6)
(cherry picked from commit a7cb5ec)
bahetimansi pushed a commit to bahetimansi/pulsar that referenced this pull request Mar 23, 2025
@coderzc @bahetimansi
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough s…
b4100e0 
…yntax (apache#22867)" (apache#22921)

(cherry picked from commit fa74538)
(cherry picked from commit 59fa1a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

Assignees

@lhotari lhotari

Labels

area/cli cherry-picked/branch-3.0 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.6 release/3.2.4 release/3.3.1

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lhotari @RobertIndie