Skip to content

[improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD#21129

Merged
Technoboy- merged 3 commits into
apache:masterfrom
AnonHxy:pip-300
Sep 25, 2023
Merged

[improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD#21129
Technoboy- merged 3 commits into
apache:masterfrom
AnonHxy:pip-300

Conversation

@AnonHxy

@AnonHxy AnonHxy commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

DISCUSS thread
VOTE thread

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@AnonHxy AnonHxy changed the title [improve][pip] PIP301: Introduce LoadBalanceResources to unify the loa… [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the loa… Sep 5, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Sep 5, 2023
@AnonHxy AnonHxy changed the title [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the loa… [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date handle Sep 5, 2023
@AnonHxy AnonHxy changed the title [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date handle [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD Sep 5, 2023
@heesung-sohn

heesung-sohn commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

LGTM.

But we also have broker-level load data too. Don't we want to add it here?

@AnonHxy AnonHxy self-assigned this Sep 6, 2023
@AnonHxy

AnonHxy commented Sep 6, 2023

Copy link
Copy Markdown
Contributor Author

LGTM.

But we also have broker-level load data too. Don't we want to add it here?

The broeker-level data(/loadbalance/brokers/xxx) is handled by LockManager. Broker needs acquire a lock when starts. It's not a simple CRUD, so I think it's not suitable to put it here @heesung-sn

@AnonHxy

AnonHxy commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

@Technoboy- Technoboy- added this to the 3.2.0 milestone Sep 18, 2023
@Technoboy-

Copy link
Copy Markdown
Contributor

Need to update the vote thread

@AnonHxy

AnonHxy commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Need to update the vote thread

OK. I will start the VOTE later.

@Technoboy- Technoboy- merged commit 5c9b72a into apache:master Sep 25, 2023
AnonHxy added a commit that referenced this pull request Oct 8, 2023
### Motivation

See pip: #21129

### Modifications

Add  `BundleDataResources`
liangyuanpeng pushed a commit to liangyuanpeng/pulsar that referenced this pull request Oct 11, 2023
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
vinayakmalik95 pushed a commit to tmdc-io/pulsar that referenced this pull request Oct 12, 2023
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
AnonHxy added a commit that referenced this pull request Oct 23, 2023
#21353)

### Motivation

See pip: #21129

### Modifications

Add  `BrokerTimeAverageDataResources`
AnonHxy added a commit that referenced this pull request Dec 5, 2023
### Motivation

See pip: #21129

### Modifications

Add  `QuotaResources`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/PIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants