Skip to content

[refactor][broker] PIP-301 Part-3: Add QuotaResources#21596

Merged
AnonHxy merged 1 commit into
apache:masterfrom
AnonHxy:pip301_3
Dec 5, 2023
Merged

[refactor][broker] PIP-301 Part-3: Add QuotaResources#21596
AnonHxy merged 1 commit into
apache:masterfrom
AnonHxy:pip301_3

Conversation

@AnonHxy

@AnonHxy AnonHxy commented Nov 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

See pip: #21129

Modifications

Add QuotaResources

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

AnonHxy#48

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Nov 20, 2023
@AnonHxy AnonHxy mentioned this pull request Nov 20, 2023
Closed
@AnonHxy AnonHxy self-assigned this Nov 20, 2023
@AnonHxy AnonHxy changed the title [improve][broker] PIP-301 Part-3: Add QuotaResources [refactor][broker] PIP-301 Part-3: Add QuotaResources Nov 20, 2023
@codecov-commenter

codecov-commenter commented Nov 21, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.30%. Comparing base (cbdb19c) to head (d32851d).
Report is 1404 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21596      +/-   ##
============================================
+ Coverage     73.27%   73.30%   +0.03%     
- Complexity    32694    32716      +22     
============================================
  Files          1892     1892              
  Lines        140707   140684      -23     
  Branches      15483    15490       +7     
============================================
+ Hits         103098   103130      +32     
+ Misses        29496    29453      -43     
+ Partials       8113     8101      -12
Flag Coverage Δ
inttests 24.13% <52.38%> (-0.02%) ⬇️
systests 24.67% <52.38%> (+0.02%) ⬆️
unittests 72.62% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../pulsar/broker/resources/LoadBalanceResources.java 100.00% <100.00%> (ø)
.../org/apache/pulsar/broker/cache/BundlesQuotas.java 100.00% <100.00%> (ø)
...roker/loadbalance/impl/ModularLoadManagerImpl.java 83.52% <100.00%> (-1.51%) ⬇️
...rg/apache/pulsar/broker/service/BrokerService.java 81.13% <100.00%> (-0.25%) ⬇️

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AnonHxy

AnonHxy commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

@Technoboy- @codelipenghui @congbobo184 @poorbarcode @eolivelli PTAL. Thanks

@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 4, 2023
@AnonHxy AnonHxy merged commit 5531524 into apache:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@merlimat merlimat Awaiting requested review from merlimat

@HQebupt HQebupt Awaiting requested review from HQebupt

@congbobo184 congbobo184 Awaiting requested review from congbobo184

Assignees

@AnonHxy AnonHxy

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AnonHxy @codecov-commenter @Technoboy-