[fix][fn] Go functions must retrieve consumers by non-partitioned topic ID#20413
Merged
Technoboy- merged 1 commit intoMay 31, 2023
Merged
Conversation
Contributor
Author
|
This PR supplants #19372, which, in addition to targeting the master branch, has been sitting around long enough to become pretty out of date. Since this is a fairly nasty bug, I'm submitting this variant now to facilitate a faster merge. CC: @freeznet @wolfstudy for review. and @pocockn, who brought it to my attention again in Slack |
BewareMyPower
approved these changes
May 28, 2023
freeznet
approved these changes
May 29, 2023
Technoboy-
pushed a commit
that referenced
this pull request
May 31, 2023
…ic ID (#20413) Co-authored-by: Andy Walker <andy@andy.dev>
Technoboy-
pushed a commit
that referenced
this pull request
May 31, 2023
…ic ID (#20413) Co-authored-by: Andy Walker <andy@andy.dev>
michaeljmarshall
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 6, 2023
…ic ID (apache#20413) Co-authored-by: Andy Walker <andy@andy.dev> (cherry picked from commit fb1b46e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19367
Modifications
Retrieve consumers from the index based off of non-partitioned topic name.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Note: there is no e2e for Go pulsar functions. Verifying this change is a matter of not having panics when using pulsar functions with partitioned topics.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: flowchartsman#3