Skip to content

[fix][broker] Fix function-go can't auto ack (#19367)#19372

Open
quinniup wants to merge 6 commits into
apache:masterfrom
quinniup:master
Open

[fix][broker] Fix function-go can't auto ack (#19367)#19372
quinniup wants to merge 6 commits into
apache:masterfrom
quinniup:master

Conversation

@quinniup

@quinniup quinniup commented Jan 31, 2023

Copy link
Copy Markdown

Fixes: #19367

Motivation

  • Fixed function-go auto ack error: invalid memory address or nil pointer dereference.

Modifications

  • Ensure that the key is consistent when accessing the map.

This change is already covered by existing tests, such as (please describe tests).

Documentation

  • doc-not-needed

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 31, 2023
@quinniup

quinniup commented Feb 3, 2023

Copy link
Copy Markdown
Author

@wolfstudy

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #19372 (959a06f) into master (1cd1aef) will increase coverage by 37.10%.
The diff coverage is n/a.

❗ Current head 959a06f differs from pull request most recent head 00cad32. Consider uploading reports for the commit 00cad32 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19372       +/-   ##
=============================================
+ Coverage     26.61%   63.72%   +37.10%     
- Complexity     6358    25978    +19620     
=============================================
  Files          1568     1819      +251     
  Lines        120927   133164    +12237     
  Branches      13216    14665     +1449     
=============================================
+ Hits          32189    84860    +52671     
+ Misses        84128    40546    -43582     
- Partials       4610     7758     +3148     
Flag Coverage Δ
inttests 24.83% <ø> (-0.02%) ⬇️
systests 25.58% <ø> (?)
unittests 61.02% <ø> (+43.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/common/api/AuthData.java 71.42% <0.00%> (ø)
.../apache/pulsar/broker/namespace/LookupOptions.java 87.50% <0.00%> (ø)
.../apache/pulsar/common/naming/SystemTopicNames.java 55.55% <0.00%> (ø)
...apache/pulsar/common/util/SafeCollectionUtils.java 0.00% <0.00%> (ø)
...pache/pulsar/common/configuration/BindAddress.java 22.22% <0.00%> (ø)
...lsar/client/impl/conf/ReaderConfigurationData.java 81.39% <0.00%> (ø)
...r/client/admin/internal/data/AuthPoliciesImpl.java 65.21% <0.00%> (ø)
...sar/common/policies/data/impl/BundlesDataImpl.java 92.30% <0.00%> (ø)
...ar/common/policies/data/InactiveTopicPolicies.java 83.33% <0.00%> (ø)
...ava/org/apache/pulsar/io/file/utils/GZipFiles.java 68.18% <0.00%> (ø)
... and 1354 more

@github-actions

github-actions Bot commented Apr 7, 2023

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Apr 7, 2023
@pocockn

pocockn commented May 19, 2023

Copy link
Copy Markdown

Any update on this?

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Jun 19, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Jul 31, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 14, 2024
@lhotari lhotari removed this from the 4.1.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [pulsar-function-go] function process ackInputMessage error

7 participants