[improve][client] Exclude log4j-slf4j-impl from compile dep in pulsar-client-all#19937
Merged
Conversation
…-client-all Signed-off-by: tison <wander4096@gmail.com>
eolivelli
approved these changes
Mar 27, 2023
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
good catch
would you fix it also in bookkeeper ?
there is an ongoing VOTE for 4.16.0
hezhangjian
approved these changes
Mar 27, 2023
Member
Author
I'm glad to do so. But updating dependencies can be tricky. I have a conversation with @shoothzj and he has some ideas to improve the overall situation. I'll wait for his updates. Anyway, file an issue at apache/bookkeeper#3891 |
Member
|
sorry for my late reply. @eolivelli @tisonkun I have submit a PR for review apache/bookkeeper#3892. |
Member
Author
|
Merging.. After we upgrade to BK 4.16.0, we can revisit this issue and do some cleanups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #19484.
The root cause may be apache/bookkeeper@f0988dd#r106236889 and we bump to affected BK version in Pulsar 2.11.
Motivation
Avoid pull in log4j-slf4j-impl in pulsar-client-all.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: