[ISSUE 3891] Optimize log4j dependency in Bookkeeper#3892
Merged
Conversation
Member
Author
|
I verified the module doesn't contains log4j dependency. And the server package contains it. |
hangc0276
approved these changes
Mar 28, 2023
Contributor
|
I will trigger a new RC for 4.16.0 to include this PR. |
tisonkun
approved these changes
Mar 28, 2023
Member
|
Thanks for taking care of this! |
hangc0276
pushed a commit
that referenced
this pull request
Mar 29, 2023
(cherry picked from commit e440132)
zymap
pushed a commit
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit e440132)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current parent pom in Bookkeeper includes log4j-core and slf4j-log4j-impl dependencies, which are being transitively passed down to many modules. This has resulted in an unnecessary increase in the number of dependencies for these modules.
Changes
Fix #3891
Also see