[fix][client] Remove consumer when close consumer command is received#15761
Merged
Conversation
Member
Author
|
/pulsarbot rerun-failure-checks |
Member
|
Do you mean that testSeekByFunctionAndMultiTopic is a flaky test? |
Member
Author
|
@RobertIndie It should be stable, maybe I add the message inclusive feature breaks this, but I cannot find the root cause. I tried this code to test the If you are interested in this, we can find the root cause together. |
Member
Author
|
/pulsarbot rerun-failure-checks |
gaoran10
reviewed
May 31, 2022
gaoran10
left a comment
Contributor
There was a problem hiding this comment.
It seems that the producer has the same problem. We can fix it in another PR.
Member
Author
Yes, I can make a PR to fix the |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Member
Author
|
/pulsarbot rerun-failure-checks |
eolivelli
approved these changes
Jun 10, 2022
codelipenghui
approved these changes
Jun 10, 2022
Technoboy-
approved these changes
Jun 11, 2022
mattisonchao
approved these changes
Jun 13, 2022
michaeljmarshall
approved these changes
Jun 13, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 4, 2022
…apache#15761) (cherry picked from commit 5246c8e) (cherry picked from commit 2251e6e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com
Motivation
When the close consumer command is received, we just disconnected and didn't remove the cache, which will cause us to receive repeated messages.
This case happened in
org.apache.pulsar.broker.service.SubscriptionSeekTest#testSeekByFunctionAndMultiTopictest of #15568.Modifications
remove()instead ofget()Documentation
no-need-doc