[PIP-150][improve][broker] Support read the message of startMessageId position on the broker side#15568
[PIP-150][improve][broker] Support read the message of startMessageId position on the broker side#15568nodece wants to merge 1 commit into
Conversation
216b7a7 to
dacd590
Compare
|
/pulsarbot rerun-failure-checks |
3 similar comments
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
|
Blocked by #15761 |
|
/pulsarbot rerun-failure-checks |
| switch (initialPosition) { | ||
| case Latest: | ||
| initializeCursorPosition(ledger.getLastPositionAndCounter()); | ||
| initializeCursorPosition(ledger.getLastPositionAndCounter(), inclusive); |
There was a problem hiding this comment.
According to the PIP. Just when startMessageId == latest, need judge inclusive. We can keep the initializeCursorPosition method unchanged and add inclusive param to the getLastPositionAndCounter method.
There was a problem hiding this comment.
initializeCursorPosition will read the next valid position from this position, so I think to handle this is better in initializeCursorPosition.
|
/pulsarbot rerun-failure-checks |
|
Then blocked by |
| * @return the ManagedCursor | ||
| * @throws ManagedLedgerException | ||
| */ | ||
| ManagedCursor openCursor(String name, InitialPosition initialPosition, Map<String, Long> properties, |
There was a problem hiding this comment.
Could you add default override methods for compatibility? Because they are common APIs that can be used by other components like protocol handler.
e.g.
default void asyncOpenCursor(String name, InitialPosition initialPosition, Map<String, Long> properties,
Map<String, String> cursorProperties, OpenCursorCallback callback, Object ctx) {
asyncOpenCursor(name, initialPosition, properties, cursorProperties, false, callback, ctx);
}|
This PR has been blocked by #16171. |
a895a59 to
c372120
Compare
… position on the broker side Signed-off-by: Zixuan Liu <nodeces@gmail.com>
|
The pr had no activity for 30 days, mark with Stale label. |
|
No reviewer, so close this PR. |
Fixes #14883
Motivation
See #14883
Modifications
start_message_id_inclusivefield toCommandSubscribemessagestart_message_id_inclusivevalue ofCommandSubscribemessageNonDurableCursorImpl.javaandManagedCursorImpl.javasupports reading the message of startMessageId positionVerifying this change
Documentation
Need to update docs?
no-need-docdoc-not-needed