Skip to content

Conversation

@kaushik-develop
Copy link
Contributor

…he behavior of subscribe()"

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

codelipenghui pushed a commit that referenced this pull request Sep 22, 2021
Link PR in KoP:
streamnative/kop#718 and [failed test unit](https://github.com/streamnative/kop/pull/718/checks?check_run_id=3541827178#step:5:353)

### Motivation
The bug cause by #11012, the `loadOrCreatePersistentTopic` has uncaught exception may cause `getTopic` hang.

### Modifications

Caught the exception

### Verifying this change

The [unit test](#11290) added by @kaushik-develop help to isolate and reproduce the issue.

### Documentation
- [x] no-need-doc 
  
This is a bug fix, no need documentation.
@codelipenghui
Copy link
Contributor

The pr had no activity for 30 days, mark with Stale label.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

@kaushik-develop:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Link PR in KoP:
streamnative/kop#718 and [failed test unit](https://github.com/streamnative/kop/pull/718/checks?check_run_id=3541827178#step:5:353)

### Motivation
The bug cause by apache#11012, the `loadOrCreatePersistentTopic` has uncaught exception may cause `getTopic` hang.

### Modifications

Caught the exception

### Verifying this change

The [unit test](apache#11290) added by @kaushik-develop help to isolate and reproduce the issue.

### Documentation
- [x] no-need-doc 
  
This is a bug fix, no need documentation.
@tisonkun
Copy link
Member

tisonkun commented Dec 9, 2022

Closed as stale. Please rebase and resubmit the patch if it's still relevant.

@tisonkun tisonkun closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants