PIP-45: Migrate OwnershipCache to use MetadataStore #11012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
Jun 22, 2021
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
I did a first pass.
the patch is very big and I am not used to this code but overall it looks good
| boolean replicatedSubscriptionStateArg, | ||
| KeySharedMeta keySharedMeta) { | ||
| return brokerService.checkTopicNsOwnership(getName()).thenCompose(__ -> { | ||
| if (readCompacted && !(subType == SubType.Failover || subType == SubType.Exclusive)) { |
Contributor
There was a problem hiding this comment.
we could move this validation outside of the checkTopicNsOwnership block.
not a big deal, it is something that does not happen in the happy path
Member
|
@merlimat thanks for your contribution. For this PR, do we need to update docs? |
Contributor
Author
No docs updates, this is just an internal refactoring. |
eolivelli
approved these changes
Jul 2, 2021
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I see that the patch contains the fix on MLTransactionLog
we can merge that patch and then rebase this one
Contributor
Author
Yes, I've added here to make sure all the other tests were fine. I'll rebase on master once the other one is merged |
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Sep 22, 2021
Link PR in KoP: streamnative/kop#718 and [failed test unit](https://github.com/streamnative/kop/pull/718/checks?check_run_id=3541827178#step:5:353) ### Motivation The bug cause by #11012, the `loadOrCreatePersistentTopic` has uncaught exception may cause `getTopic` hang. ### Modifications Caught the exception ### Verifying this change The [unit test](#11290) added by @kaushik-develop help to isolate and reproduce the issue. ### Documentation - [x] no-need-doc This is a bug fix, no need documentation.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* PIP-45: Migrate OwnershipCache to use MetadataStore * Import checkstyle * Fixed typo * Addressed comment * Fixed test * Test fixes * One more test fix * Fixed possible deadlock in the initialization of MLTransactionLog * Fixed tests
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Link PR in KoP: streamnative/kop#718 and [failed test unit](https://github.com/streamnative/kop/pull/718/checks?check_run_id=3541827178#step:5:353) ### Motivation The bug cause by apache#11012, the `loadOrCreatePersistentTopic` has uncaught exception may cause `getTopic` hang. ### Modifications Caught the exception ### Verifying this change The [unit test](apache#11290) added by @kaushik-develop help to isolate and reproduce the issue. ### Documentation - [x] no-need-doc This is a bug fix, no need documentation.
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Apr 11, 2024
… creating OwnershipCache ### Motivation apache#11012 removes all uses of the `NamespaceBundleFactory` field in `OwnershipCache` and apache#17768 removes that field. However, the constructor of `OwnershipCache` still has the `NamespaceBundleFactory` parameter. ### Modifications Remove that parameter from the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate OwnershipCache logic for acquiring and watching bundles ownership to use ResourceLocks from the MetadataStore interface.