Skip to content

MINOR: Bump system test version from 2.2.1 to 2.2.2#7765

Merged
rhauch merged 2 commits into
apache:trunkfrom
rhauch:minor-add-222-to-system-tests
Dec 6, 2019
Merged

MINOR: Bump system test version from 2.2.1 to 2.2.2#7765
rhauch merged 2 commits into
apache:trunkfrom
rhauch:minor-add-222-to-system-tests

Conversation

@rhauch

@rhauch rhauch commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch

rhauch commented Dec 1, 2019

Copy link
Copy Markdown
Contributor Author

System test run with this PR: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3597/

ijuma
ijuma reviewed Dec 2, 2019
View reviewed changes
Comment thread vagrant/base.sh Outdated

@ijuma ijuma Dec 2, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do 2.3.0 -> 2.3.1 at the same time?

@rhauch rhauch Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

ijuma
ijuma approved these changes Dec 2, 2019
View reviewed changes

@ijuma ijuma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass.

@rhauch rhauch force-pushed the minor-add-222-to-system-tests branch from fa8f25e to 899f2d5 Compare December 3, 2019 21:54
@rhauch

rhauch commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

Both JDK 11 builds passed, but the JDK 8 build passed with an error that IIUC does not attempt to use older Kafka versions:

kafka.server.ApiVersionsRequestTest > testApiVersionsRequestValidationV3 STARTED
kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete failed, log available in /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk8-scala2.11/core/build/reports/testOutput/kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete.test.stdout

kafka.integration.MetricsDuringTopicCreationDeletionTest > testMetricsDuringTopicCreateDelete FAILED
    java.lang.AssertionError: assertion failed: UnderReplicatedPartitionCount not 0: 1
        at scala.Predef$.assert(Predef.scala:170)
        at kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete(MetricsDuringTopicCreationDeletionTest.scala:123)

@rhauch

rhauch commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

Previous system test run failed with 2.2.2 TAR file not available on S3. Added the missing artifacts to the S3 bucket, and running again: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3609/

@rhauch

rhauch commented Dec 5, 2019

Copy link
Copy Markdown
Contributor Author

Build 3609 failed on one test:

Module: kafkatest.tests.core.round_trip_fault_test
Class:  RoundTripFaultTest
Method: test_produce_consume_with_client_partition

Rerunning as https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3615/

@rhauch

rhauch commented Dec 6, 2019

Copy link
Copy Markdown
Contributor Author

Last system test failure resulted in 1 failure:

Module: kafkatest.tests.connect.connect_distributed_test Class:  ConnectDistributedTest Method: test_pause_state_persistent Arguments: {   "connect_protocol": "sessioned" }

This appears to be a flaky test and timeout related (see #7790, #7789 for fixes), and not one that uses older broker versions. So this PR shouldn't affect that test.

I'll wait to merge until those two PRs are merged, however.

@rhauch rhauch merged commit ccded34 into apache:trunk Dec 6, 2019
rhauch added a commit that referenced this pull request Dec 6, 2019
@rhauch
MINOR: Bump system test version from 2.2.1 to 2.2.2 (#7765)
82d2446 
Author: Randall Hauch <rhauch@gmail.com>
Reviewer: Ismael Juma <ismael@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

Assignees

No one assigned

Labels

connect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhauch @ijuma @kkonstantine