Skip to content

MINOR: Increase the timeout in one of Connect's distributed system tests#7790

Merged
rhauch merged 1 commit into
apache:2.2from
rhauch:minor-increase-connect-distributed-test-timeout-2.2
Dec 6, 2019
Merged

MINOR: Increase the timeout in one of Connect's distributed system tests#7790
rhauch merged 1 commit into
apache:2.2from
rhauch:minor-increase-connect-distributed-test-timeout-2.2

Conversation

@rhauch

@rhauch rhauch commented Dec 6, 2019

Copy link
Copy Markdown
Contributor

System test fails sometimes because Connect restarts around 30 seconds, so increasing timeout to 70 seconds (similar to other tests in same class).

Can be backported to 2.1; see #7789 for similar fix on trunk, 2.4, and 2.3.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ncliang ncliang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvcephei vvcephei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rhauch

I assume you actually ran these system tests to make sure they still work?

@rhauch

rhauch commented Dec 6, 2019

Copy link
Copy Markdown
Contributor Author

I didn't because the change was simple enough, but I've kicked off a build: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3622/

@rhauch

rhauch commented Dec 6, 2019

Copy link
Copy Markdown
Contributor Author

Run of all Connect system tests passed.

@rhauch rhauch merged commit 77eecb2 into apache:2.2 Dec 6, 2019
rhauch added a commit that referenced this pull request Dec 6, 2019
…sts (#7790)

Author: Randall Hauch <rhauch@gmail.com>
Reviewers: Nigel Liang <nigel@nigelliang.com>, Roesler <john@confluent.io>
rhauch added a commit that referenced this pull request Dec 6, 2019
…sts (#7790)

Author: Randall Hauch <rhauch@gmail.com>
Reviewers: Nigel Liang <nigel@nigelliang.com>, Roesler <john@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants