MINOR: Avoid dividing by zero#7143
Merged
Merged
Conversation
mjsax
commented
Aug 1, 2019
| committed = taskManager.maybeCommitActiveTasksPerUserRequested(); | ||
| if (committed > 0) { | ||
| final long requestCommitLatency = advanceNowAndComputeLatency(); | ||
| commitSensor.record(requestCommitLatency / (double) committed, now); |
Member
Author
There was a problem hiding this comment.
The problem was here: committed could be zero without this fix.
Member
There was a problem hiding this comment.
Seems like this should have noticeably screwed up these metrics, do we think this branch is just rarely seen or no one has noticed somehow?
Member
Author
There was a problem hiding this comment.
I think it's rarely executed. Only if a PAPI user request committing via context.commit(), what is expected to be rarely used feature.
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna @abbccdda |
cadonna
approved these changes
Aug 1, 2019
bbejeck
approved these changes
Aug 1, 2019
Member
|
retest this please |
guozhangwang
approved these changes
Aug 1, 2019
Member
Author
|
Java 11 / 2.13 and Java8 failed with know flaky tests (tracked in Jira). Java 11 / 2.12 passed. Retest this please. |
Member
Author
|
Java8 passed. Retest this please. |
Member
Author
|
Java 11 / 2.13 and Java 8 passed. Java 11 / 2.12 passed in a previous run. Merging. |
mjsax
added a commit
that referenced
this pull request
Aug 3, 2019
Reviews: A. Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bill@confluent.io>, Bruno Cadonna <bruno@confluent.io>, Boyang Chen <boyang@confluent.io>, Guozhang Wang <guozhang@confluent.io>
Member
Author
|
Merged to |
mjsax
added a commit
that referenced
this pull request
Aug 3, 2019
Reviews: A. Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bill@confluent.io>, Bruno Cadonna <bruno@confluent.io>, Boyang Chen <boyang@confluent.io>, Guozhang Wang <guozhang@confluent.io>
mapr-devops
pushed a commit
to mapr/kafka
that referenced
this pull request
Aug 4, 2019
Reviews: A. Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bill@confluent.io>, Bruno Cadonna <bruno@confluent.io>, Boyang Chen <boyang@confluent.io>, Guozhang Wang <guozhang@confluent.io>
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 4, 2019
* apache-github/2.3: MINOR: Avoid dividing by zero (apache#7143) KAFKA-8731: InMemorySessionStore throws NullPointerException on startup (apache#7132) KAFKA-8715; Fix buggy reliance on state timestamp in static member.id generation (apache#7116) KAFKA-8678; Fix leave group protocol bug in throttling and error response (apache#7101)
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 22, 2019
TICKET = LI_DESCRIPTION = EXIT_CRITERIA = HASH [7b52feb] ORIGINAL_DESCRIPTION = Reviews: A. Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bill@confluent.io>, Bruno Cadonna <bruno@confluent.io>, Boyang Chen <boyang@confluent.io>, Guozhang Wang <guozhang@confluent.io> (cherry picked from commit 7b52feb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntelliJ showed a warning about it...
This affects
2.3,2.2, and2.1and we should backport the fix.