KAFKA-8678: fix leave group protocol bug in throttling and error response#7101
Merged
Conversation
Author
|
retest this please |
guozhangwang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the added test coverage, lgtm except one question.
| return version >= 2; | ||
| } | ||
|
|
||
| @Override |
Contributor
There was a problem hiding this comment.
Is it necessary to add equals and hashCode in this fix?
Author
There was a problem hiding this comment.
It should be useful for unit test purpose.
hachikuji
reviewed
Jul 18, 2019
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
Thanks, good find. Left a couple comments.
hachikuji
approved these changes
Jul 18, 2019
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just one additional comment.
Contributor
There was a problem hiding this comment.
nit: use ApiKeys.LEAVE_GROUP.latestVersion() here also
Author
|
retest this please |
1 similar comment
Author
|
retest this please |
Author
|
We already got 4 1/3 builds and manually checked all tests failures are flaky. Will kick off one more to aim for 2/3 retest this please |
hachikuji
pushed a commit
that referenced
this pull request
Jul 22, 2019
…onse (#7101) This is a bug fix PR to resolve errors introduced in #6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Jul 22, 2019
…onse (#7101) This is a bug fix PR to resolve errors introduced in #6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io>
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 4, 2019
* apache-github/2.3: MINOR: Avoid dividing by zero (apache#7143) KAFKA-8731: InMemorySessionStore throws NullPointerException on startup (apache#7132) KAFKA-8715; Fix buggy reliance on state timestamp in static member.id generation (apache#7116) KAFKA-8678; Fix leave group protocol bug in throttling and error response (apache#7101)
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 22, 2019
…n throttling and error response (apache#7101) TICKET = KAFKA-8678 LI_DESCRIPTION = EXIT_CRITERIA = HASH [f94ec1c] ORIGINAL_DESCRIPTION = This is a bug fix PR to resolve errors introduced in apache#6188. The PR fixes 2 things: 1. throttle time should be set on version >= 1 instead of version >= 2 2. `getErrorResponse` should set throwable exception within LeaveGroupResponseData The patch also adds more unit tests to guarantee correctness for leave group protocol. Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jason Gustafson <jason@confluent.io> (cherry picked from commit f94ec1c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix PR to resolve errors introduced in #6188.
The PR fixes 2 things:
getErrorResponseshould set throwable exception within LeaveGroupResponseDataIn the meanwhile, adding more unit tests to guarantee correctness for leave group protocol.
Committer Checklist (excluded from commit message)