KAFKA-1833: OfflinePartitionLeaderSelector may return null leader when ISR and Assgi...#39
Closed
tedxia wants to merge 1 commit into
Closed
KAFKA-1833: OfflinePartitionLeaderSelector may return null leader when ISR and Assgi...#39tedxia wants to merge 1 commit into
tedxia wants to merge 1 commit into
Conversation
…sgined Broker have no common broker
Contributor
|
Hi @tedxia do you mind please to use the review tool https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool so folks can review your patch on JIRA, thanks! |
Author
|
@joestein I have add patch through kafka patch review tool, please review it, thank you. |
Author
|
Will somebody have a look at this, thanks a lot; |
guozhangwang
added a commit
to guozhangwang/kafka
that referenced
this pull request
Sep 9, 2015
Fix ProcessorJob; rename streaming to streams
resetius
added a commit
to resetius/kafka
that referenced
this pull request
Apr 22, 2016
Contributor
|
@tedxia Sorry for late reviews. I think this behavior is by-design that if there is no live brokers in the assigned replicas, we will return null leader indicating that this partition is offline. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Author
|
ok, I will close this issue. |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
satishd
referenced
this pull request
in satishd/kafka
Mar 23, 2020
MINOR Refactored `deleteLogSegment` API to return void and always throw RemoteStorageException if the operation is failed.
smccauliff
pushed a commit
to smccauliff/kafka
that referenced
this pull request
Oct 8, 2020
…ompatibility (apache#39) TICKET = LI_DESCRIPTION = Some apps such as linkedin-kafka-clients and likafka-cruise-control still reply on this API: parseAndValidateAddresses(List<String> urls). This patch adds back the function. EXIT_CRITERIA = MANUAL ["when no APP makes direct use of this API"]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 7, 2022
…ompatibility (apache#39) TICKET = LI_DESCRIPTION = Some apps such as linkedin-kafka-clients and likafka-cruise-control still reply on this API: parseAndValidateAddresses(List<String> urls). This patch adds back the function. EXIT_CRITERIA = MANUAL ["when no APP makes direct use of this API"]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…ompatibility (apache#39) TICKET = LI_DESCRIPTION = Some apps such as linkedin-kafka-clients and likafka-cruise-control still reply on this API: parseAndValidateAddresses(List<String> urls). This patch adds back the function. EXIT_CRITERIA = MANUAL ["when no APP makes direct use of this API"]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…ompatibility (apache#39) TICKET = LI_DESCRIPTION = Some apps such as linkedin-kafka-clients and likafka-cruise-control still reply on this API: parseAndValidateAddresses(List<String> urls). This patch adds back the function. EXIT_CRITERIA = MANUAL ["when no APP makes direct use of this API"]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…ompatibility (apache#39) TICKET = LI_DESCRIPTION = Some apps such as linkedin-kafka-clients and likafka-cruise-control still reply on this API: parseAndValidateAddresses(List<String> urls). This patch adds back the function. EXIT_CRITERIA = MANUAL ["when no APP makes direct use of this API"]
kamalcph
added a commit
to kamalcph/kafka
that referenced
this pull request
Sep 21, 2022
* Tests added for UnifiedLog, RemoteIndexCache, LeaderEpochFileCache and ProducerStateManager * RemoteLogManager instantiation test on KafkaServer and BrokerServer added. * LeaderEpochFileCache assign-without-flush test case added. * Covered test for UnifiedLog#legacyFetchOffsetsBefore
lianetm
added a commit
to lianetm/kafka
that referenced
this pull request
Aug 8, 2023
rustd
pushed a commit
to rustd/pranavfinaldemokafka
that referenced
this pull request
Feb 9, 2024
Tests for 21a15c6 Implements KIP-862: https://cwiki.apache.org/confluence/x/WSf1D Reviewer: John Roesler <vvcephei@apache.org> Co-authored-by: Vicky Papavasileiou <vpapavas@users.noreply.github.com>
patrik-marton
pushed a commit
to patrik-marton/kafka
that referenced
this pull request
Mar 11, 2025
CSMDS-525: Bump stack version to 1.1.0 MINOR: increase unit test retry from 3 to 5 (CSMDS-493 workaround) (apache#39)
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Nov 6, 2025
Add mirror fetcher refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for KAFKA-1833
In OfflinePartitonLeaderSelector::selectLeader, when liveBrokerInIsr is not empty and have no common broker with liveAssignedreplicas, selectLeader will return no leader;