KAFKA-14209 : Integration tests 3/3#12676
Merged
Merged
Conversation
vvcephei
reviewed
Oct 5, 2022
vvcephei
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @vpapavas !
This looks good to me overall, just two points:
- I was confused by the name of a test (see below)
- What's the contract if you run with the flag enabled and then disable it? I assume you have to reset the application, since we would have only the LHS store populated. Is there any warning or error that we produce? If so, then we should test for it. If not, then we should make sure it's well documented.
vvcephei
approved these changes
Oct 6, 2022
Contributor
There was a problem hiding this comment.
Thanks, @vpapavas !
After discussing offline, we'll rename this method and file a follow-on task to clarify the docs that disabling the optimization once enabled is not supported (an application reset would be required). This is pretty typical for optimizations anyway.
That update is orthogonal to this test, though, so it need not block this PR.
…fJoinUpgradeIntegrationTest.java
Contributor
|
These test failures are not related: |
showuon
pushed a commit
that referenced
this pull request
Nov 5, 2022
Tests for 21a15c6 Implements KIP-862: https://cwiki.apache.org/confluence/x/WSf1D Reviewer: John Roesler <vvcephei@apache.org>
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
Tests for 21a15c6 Implements KIP-862: https://cwiki.apache.org/confluence/x/WSf1D Reviewer: John Roesler <vvcephei@apache.org>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Tests for 21a15c6 Implements KIP-862: https://cwiki.apache.org/confluence/x/WSf1D Reviewer: John Roesler <vvcephei@apache.org>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Tests for 21a15c6 Implements KIP-862: https://cwiki.apache.org/confluence/x/WSf1D Reviewer: John Roesler <vvcephei@apache.org> Co-authored-by: Vicky Papavasileiou <vpapavas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test and upgrade test for the self-join rewriting. The upgrade test ensures that a user does not lose data if they have a topology without the rewriting and then turn-on the rewriting.
Committer Checklist (excluded from commit message)