KAFKA-1635: Fixed incorrect java doc of makeLeaders() in ReplicaManager#33
Closed
LantaoJin wants to merge 1 commit into
Closed
KAFKA-1635: Fixed incorrect java doc of makeLeaders() in ReplicaManager#33LantaoJin wants to merge 1 commit into
LantaoJin wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the patch. Committed to trunk. |
Author
|
Ok, thanks. I will close this pull. |
ymatsuda
added a commit
to ymatsuda/kafka
that referenced
this pull request
Sep 3, 2015
enable default SerDe, optimize record inserts
resetius
added a commit
to resetius/kafka
that referenced
this pull request
Apr 22, 2016
[LOGBROKER-1343] adaptive fetchSize
ying-zheng
added a commit
to ying-zheng/kafka
that referenced
this pull request
Mar 17, 2020
Rewrite HDFS RSM using the new interface
lianetm
pushed a commit
to lianetm/kafka
that referenced
this pull request
Aug 2, 2023
* Fixing tests * update tests
fvaleri
pushed a commit
to fvaleri/kafka
that referenced
this pull request
Oct 11, 2025
Add ACL synchronization for cluster linking
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 11, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 18, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 18, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 24, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 24, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 26, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 27, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 27, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
Oct 29, 2025
This patch introduces cluster linking authentication that, along with ACL synchronization, completes the security requirements. The cluster link configuration is passed by the user via `--cluster-link-config` flag when creating a link to a remote cluster, and stored in `CONFIG_RECORD` metadata records. Key changes: - Added `clusterLinkName` to `InitialFetchState`, which is used to carry cluster link identity through the fetcher creation pipeline to enable proper authentication context. - Added `metadataCache` to `ReplicaFetcherManager`, which enables retrieval of cluster link configuration properties from `CONFIG_RECORD` metadata records. - Created `BrokerAndFetcherIdWithClusterLink` grouping key, which ensures partitions with different cluster links get separate fetcher threads with appropriate authentication. This is needed because each cluster links point to a different source cluster that may have different authentication setup. - Created `ReplicaFetcherManager.addFetcherForPartitions` that groups partitions by `clusterLinkName` so that they can be assigned to the same remote fetcher, as they share the same authentication mechanism. - Created `createClusterLinkFetcherThread` to `ReplicaFetcherManager` that uses the `metadataCache` to retrieve `clusterLinkProperties` and create `RemoteBrokerBlockingSender` with proper cluster link authentication properties. - Updated `RemoteBrokerBlockingSender` to use cluster link configuration when creating the network client. Code path: ``` ReplicaManager.applyLocalFollowersDelta (with remoteLeader=true) --> ReplicaManager.addFetcherForPartitions (clusterLinkName in InitialFetchState) --> ReplicaFetcherManager.createClusterLinkFetcherThread (clusterLinkName) --> metadataCache.config() (CLUSTER_LINK, linkName) --> new RemoteBrokerBlockingSender (with clusterLinkProperties) --> (NetworkClient connect with authentication) ``` We can reuse the manual test describe in apache#33. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.