enable default SerDe, optimize record inserts#33
Merged
Conversation
|
LGTM. Just wondering what is the benefit of pushing addRecords to RecordQueue? Admittedly this is an internal class, but I feel the old addRecord / putRecord symmetry is also OK? |
Author
|
The benefit are reduced hash lookups of RecordQueue (we used to do it for each record to insert a record and to get the queue size) and reduced call stack operations and method call overheads. Also, the use of deserializers is confined in SourceNode. It is good because neither StreamTask, PartitionGroup, RecordQueue needs to know about deserializers. |
ymatsuda
added a commit
that referenced
this pull request
Sep 3, 2015
enable default SerDe, optimize record inserts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guozhang Wang (@guozhangwang)