[GLUTEN-7028][CH][Part-14] Refactor Case Sensitive Support for MergeTree#8346
Merged
baibaichen merged 10 commits intoapache:mainfrom Dec 27, 2024
Merged
[GLUTEN-7028][CH][Part-14] Refactor Case Sensitive Support for MergeTree#8346baibaichen merged 10 commits intoapache:mainfrom
baibaichen merged 10 commits intoapache:mainfrom
Conversation
2771287 to
7809a3c
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
11 tasks
…o column name in schema
7809a3c to
8cd914b
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 27, 2024
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 28, 2024
baibaichen
pushed a commit
that referenced
this pull request
Dec 30, 2024
* [Fix UT] spark.databricks.delta.stats.skipping -> false * [Fix UT] Bucket table not support * [Fix UT] 'test cache mergetree data no partition columns' already fixed by (#8346) * [UT] open ignore test * [MINOR REFACTOR] Pass by const reference instead of pass by value * [MINOR REFACTOR] validatedPartitionID * [Fix Bug] decode part name * clang 19 fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
problem
This PR refactor how clickhosue backend supports wrting merge tree. When
spark.sql.caseSensitiveisfalse,Before this PRs, We convert column name to lower case , and save to disc, for example, given the following DDL
Here are columns.txt
16 columns:
l_orderkeyNullable(Int64)l_partkeyNullable(Int64)l_suppkeyNullable(Int64)l_linenumberNullable(Int64)l_quantityNullable(Float64)l_extendedpriceNullable(Float64)l_discountNullable(Float64)l_taxNullable(Float64)l_returnflagNullable(String)l_linestatusNullable(String)l_shipdateNullable(Date32)l_commitdateNullable(Date32)l_receiptdateNullable(Date32)l_shipinstructNullable(String)l_shipmodeNullable(String)l_commentNullable(String)16 columns:
L_ORDERKEYNullable(Int64)L_PARTKEYNullable(Int64)L_SUPPKEYNullable(Int64)L_LINENUMBERNullable(Int64)L_QUANTITYNullable(Float64)L_EXTENDEDPRICENullable(Float64)L_DISCOUNTNullable(Float64)L_TAXNullable(Float64)L_RETURNFLAGNullable(String)L_LINESTATUSNullable(String)L_SHIPDATENullable(Date32)L_COMMITDATENullable(Date32)L_RECEIPTDATENullable(Date32)L_SHIPINSTRUCTNullable(String)L_SHIPMODENullable(String)L_COMMENTNullable(String)spark.sql.caseSensitiveis a configuarion, once it is set to true,unless user force the column name to be lowercasein the sql, subsequent operations will fail, even if the column name is capitalized as declared by the user.
change
I did two chagne:
(Fixes: #7028)
How was this patch tested?
Reopen ignored UTs