Skip to content

[GLUTEN-7028][CH][Part-15] [MINOR] Fix UTs#8364

Merged
baibaichen merged 8 commits intoapache:mainfrom
baibaichen:feature/fixut
Dec 30, 2024
Merged

[GLUTEN-7028][CH][Part-15] [MINOR] Fix UTs#8364
baibaichen merged 8 commits intoapache:mainfrom
baibaichen:feature/fixut

Conversation

@baibaichen
Copy link
Copy Markdown
Contributor

@baibaichen baibaichen commented Dec 27, 2024

What changes were proposed in this pull request?

This PR fixed 3 UTs

  1. GlutenClickHouseMergeTreeCacheDataSuite::test cache mergetree data no partition columns, it's fixed by [GLUTEN-7028][CH][Part-14] Refactor Case Sensitive Support for MergeTree #8346, just reopen test
  2. GlutenClickHouseMergeTreePathBasedWriteSuite::test mergetree path based table update and GlutenClickHouseMergeTreePathBasedWriteSuite::test mergetree path based table delete, since one pipeline write will collect stats, so that pruning will be more accurate in point query, adding withSQLConf(("spark.databricks.delta.stats.skipping", "false")) to make test suucess.
  3. test mergetree with partition with whitespace, whitespace will be saved as %20 in Delta commit protocol, so that we need follow this, and hence decode it to normal string in backend.
  4. other ignored cases are bucket table case, let's ignore it.

(Fixes: #7028)

How was this patch tested?

Existed ignore uts

@github-actions
Copy link
Copy Markdown

#7028

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen marked this pull request as ready for review December 30, 2024 03:38
Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@baibaichen baibaichen merged commit eaf6548 into apache:main Dec 30, 2024
@baibaichen baibaichen deleted the feature/fixut branch December 30, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CH] Fully Support writing parquet and mergetree in spark 3.5.x with delta protocol

2 participants