Skip to content

[ISSUE-#7289] Fix some problem mention at #7289#7290

Merged
AlbumenJ merged 6 commits intoapache:masterfrom
horizonzy:fix-7289
Mar 13, 2021
Merged

[ISSUE-#7289] Fix some problem mention at #7289#7290
AlbumenJ merged 6 commits intoapache:masterfrom
horizonzy:fix-7289

Conversation

@horizonzy
Copy link
Copy Markdown
Member

@horizonzy horizonzy commented Feb 28, 2021 •
edited
Loading

For-#7289

What is the purpose of the change

  1. reset key INSTANCE_REVISION_UPDATED_KEY = dubbo.instance.revision.updated after instance update.
  2. unify register(), update(), getLocalInstance() in AbstractServiceDiscovery. kinds of serviceDiscovery should extends it.
  3. catch the schdule task at org.apache.dubbo.config.bootstrap.DubboBootstrap#registerServiceInstance

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 2, 2021 •
edited
Loading

Codecov Report

Merging #7290 (44b0df6) into master (fab59fc) will decrease coverage by 0.05%.
The diff coverage is 32.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7290      +/-   ##
============================================
- Coverage     58.67%   58.62%   -0.06%     
  Complexity      425      425              
============================================
  Files          1044     1043       -1     
  Lines         42484    42469      -15     
  Branches       6229     6197      -32     
============================================
- Hits          24928    24897      -31     
- Misses        14759    14781      +22     
+ Partials       2797     2791       -6
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/dubbo/rpc/cluster/Cluster.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...apache/dubbo/rpc/cluster/router/tag/TagRouter.java 32.25% <0.00%> (-1.75%) 0.00 <0.00> (ø)
...apache/dubbo/registry/client/ServiceDiscovery.java 24.24% <ø> (ø) 0.00 <0.00> (ø)
.../client/metadata/ServiceInstanceMetadataUtils.java 27.65% <0.00%> (-0.61%) 0.00 <0.00> (ø)
.../dubbo/registry/consul/ConsulServiceDiscovery.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ache/dubbo/registry/etcd/EtcdServiceDiscovery.java 1.21% <ø> (+0.01%) 1.00 <0.00> (ø)
.../dubbo/registry/eureka/EurekaServiceDiscovery.java 55.04% <ø> (ø) 17.00 <0.00> (ø)
...try/multiple/MultipleRegistryServiceDiscovery.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/dubbo/registry/nacos/NacosServiceDiscovery.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...bo/registry/sofa/SofaRegistryServiceDiscovery.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a2244...44b0df6. Read the comment docs.

xiaoheng1
xiaoheng1 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlbumenJ
AlbumenJ approved these changes Mar 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

horizonzy added 3 commits March 6, 2021 16:47
@horizonzy
Merge remote-tracking branch 'upstream/master' into fix-7289
cd8b894
@horizonzy
Merge branch 'master' into fix-7289
44b0df6 
# Conflicts:
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
@horizonzy
Merge branch 'master' into fix-7289
b1e5a2a
@AlbumenJ AlbumenJ merged commit 7cf6884 into apache:master Mar 13, 2021
@AlbumenJ AlbumenJ mentioned this pull request Mar 13, 2021
Closed
me0106 added a commit to me0106/dubbo that referenced this pull request Mar 14, 2021
@me0106
Merge pull request #3 from apache/master
86a4bc9 
[ISSUE-apache#7289] Fix some problem mention at apache#7289 (apache#7290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

@xiaoheng1 xiaoheng1 xiaoheng1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@horizonzy @codecov-io @AlbumenJ @xiaoheng1