Skip to content

Some problem about ServiceDiscoverty. #7289

@horizonzy

Description

@horizonzy

problems.

  1. Not all serviceDiscoveryRegistry will set localInstance, just like ServiceDiscoveryRegistry, it didn't maintain localInstance, it will cause NPE at BubboBootstrap.registerServiceInstance();
    executorRepository.nextScheduledExecutor().scheduleAtFixedRate(() -> {
    InMemoryWritableMetadataService localMetadataService = (InMemoryWritableMetadataService) WritableMetadataService.getDefaultExtension();
    localMetadataService.blockUntilUpdated();
    ServiceInstanceMetadataUtils.refreshMetadataAndInstance();
    }, 0, ConfigurationUtils.get(METADATA_PUBLISH_DELAY_KEY, DEFAULT_METADATA_PUBLISH_DELAY), TimeUnit.MICROSECONDS);

public static void refreshMetadataAndInstance() {
RemoteMetadataServiceImpl remoteMetadataService = MetadataUtils.getRemoteMetadataService();
remoteMetadataService.publishMetadata(ApplicationModel.getName());
AbstractRegistryFactory.getServiceDiscoveries().forEach(serviceDiscovery -> {
calInstanceRevision(serviceDiscovery, serviceDiscovery.getLocalInstance());
// update service instance revision
serviceDiscovery.update(serviceDiscovery.getLocalInstance());
});
}

  1. The key which is used to judge instance is update, it should be reset after update process.

  2. The subclass of ServiceDiscoverty is messed, unify the subclass process about register and update in AbstractServiceDiscovery.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions