Filter refactor, keep all callback methods inside Filter.Listener#5731
Merged
chickenlj merged 4 commits intoapache:masterfrom Feb 28, 2020
Merged
Filter refactor, keep all callback methods inside Filter.Listener#5731chickenlj merged 4 commits intoapache:masterfrom
chickenlj merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5731 +/- ##
============================================
- Coverage 61.43% 61.31% -0.13%
Complexity 497 497
============================================
Files 932 927 -5
Lines 38098 37944 -154
Branches 5500 5480 -20
============================================
- Hits 23405 23264 -141
- Misses 12149 12150 +1
+ Partials 2544 2530 -14
Continue to review full report at Codecov.
|
This was referenced Mar 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #5639 #5623